feat: add Account Settings e2e continuum tets for Email, Password, Personal Details, Notifications Pages #20126

uroslates · 2025-03-27T11:27:02Z

Closes:

…rsonal Details Pages

Pio-Bar

So far only two files run AccessContinuum tests. Let's circle back once the rest is completed and existing comments have been resolved with changes applied throughout.

You may also want to check out /storefrontapp-e2e-cypress/docs/a11y-testing.md for some reasoning behind the comments here. There should also be examples on how to specifically target modals and such.

Pio-Bar · 2025-04-02T15:26:35Z

...frontapp-e2e-cypress/cypress/e2e/accessibility/account-settings-close-account.a11y-e2e.cy.ts

+ * This test checks accessibility concerns on the Account Settings Close Account page using Access Continuum
+ */
+describe('Account Settings / Close Account Page Accessibility', () => {
+  isolateTests();


The test isolation is on on by default, I think this may be unnecessary.

Pio-Bar · 2025-04-02T15:33:03Z

...frontapp-e2e-cypress/cypress/e2e/accessibility/account-settings-close-account.a11y-e2e.cy.ts

+  it('initial page load', () => {
+    updateEmail.registerAndLogin();
+    cy.visit(CLOSE_ACCOUNT_URL);
+    cy.get('cx-breadcrumb h1').should('contain', 'Close Account');


Suggested change

cy.get('cx-breadcrumb h1').should('contain', 'Close Account');

cy.get('cx-breadcrumb h1').contains('Close Account');

We should not use assertions. Ideally we want failures to happen only if Access Continuum finds issues. Otherwise we are risking false negatives. This goes for all the tests in this PR.

Pio-Bar · 2025-04-02T15:54:38Z

...frontapp-e2e-cypress/cypress/e2e/accessibility/account-settings-close-account.a11y-e2e.cy.ts

+  it('Close Account update success', () => {
+    updateEmail.registerAndLogin();
+    cy.visit(CLOSE_ACCOUNT_URL);
+    cy.get('cx-breadcrumb h1').should('contain', 'Close Account');
+    cy.get('cx-close-account button.btn-primary').click();
+    cy.get('cx-close-account-modal .cx-close-account-modal-title').should(
+      'contain',
+      'Confirm Account Closure'
+    );
+    cy.get(
+      'cx-close-account-modal .cx-close-account-modal-footer button.btn-secondary'
+    ).click();
+
+    cy.get('main').a11yRunContinuumTest();
+  });


Not sure why the modal is opened and then closed? Access Continuum can only see what's part of the DOM while the test is run.
The main has already been tested in the previous test we should only target the modal here.

Pio-Bar · 2025-04-02T16:10:36Z

...frontapp-e2e-cypress/cypress/e2e/accessibility/account-settings-close-account.a11y-e2e.cy.ts

+  });
+
+  it('initial page load', () => {
+    updateEmail.registerAndLogin();


There is no point of having Cypress manually go through the forms. We can login with a request using cy.requireLoggedIn(standardUser); command. This should make our test run a lot faster.

If we are not making any changes to the account we should be able to just reuse one.

Pio-Bar · 2025-04-02T16:53:58Z

...2e-cypress/cypress/e2e/accessibility/account-settings-notification-preference.a11y-e2e.cy.ts

+  const checkbox = cy
+    .get('cx-notification-preference')
+    .find('input.form-check-input');
+  // TODO: Why is check causing error!?
+  return isEmailNotificationChannel ? checkbox.check() : checkbox.uncheck();


You should not use variables with cypress. Trying to access sth outside of it's queue will usually cause problems. Use aliases instead. You can read more here.

Pio-Bar · 2025-04-02T17:05:10Z

...2e-cypress/cypress/e2e/accessibility/account-settings-notification-preference.a11y-e2e.cy.ts

+  it('notification preference update success', () => {
+    updateEmail.registerAndLogin();
+    cy.visit(NOTIFICATION_PREFERENCE_URL);
+    cy.get('cx-breadcrumb h1').should('contain', 'Notification Preference');
+    cy.get('cx-notification-preference input[type="checkbox"]').should(
+      'not.be.checked'
+    );
+    updateNotificationPreferencesForm({ isEmailNotificationChannel: true });
+    cy.get('cx-notification-preference input[type="checkbox"]').should(
+      'be.checked'
+    );
+
+    cy.get('main').a11yRunContinuumTest();
+  });


Are there unique elements here compared to the previous test? Looks like we are just scanning the same thing twice.

cypress · 2025-04-03T21:25:33Z

spartacus Run #48039

Run Properties: Passed #48039 • 12063b7188 ℹ️: Merge 07547f9a08ad9fbbf44fd2f6a29ebd1572baa79d into c4fc7f81ef89914d3f1ce4814c0f...

Project	`spartacus`
Branch Review	`feature/CXSPA-9722`
Run status	`Passed #48039`
Run duration	`04m 55s`
Commit	`12063b7188 ℹ️: Merge 07547f9a08ad9fbbf44fd2f6a29ebd1572baa79d into c4fc7f81ef89914d3f1ce4814c0f...`
Committer	`Uros Lates`
View all properties for this run ↗︎

Test results
Failures	`0`
Flaky	`3`
Pending	`2`
Skipped	`0`
Passing	`152`
View all changes introduced in this branch ↗︎

...frontapp-e2e-cypress/cypress/e2e/accessibility/account-settings-close-account.a11y-e2e.cy.ts

...ntapp-e2e-cypress/cypress/e2e/accessibility/account-settings-personal-details.a11y-e2e.cy.ts

...frontapp-e2e-cypress/cypress/e2e/accessibility/account-settings-close-account.a11y-e2e.cy.ts

feat: add Account Settings e2e continuum tets for Email, Password, Pe…

4eff776

…rsonal Details Pages

github-actions bot marked this pull request as draft March 27, 2025 11:27

uroslates and others added 3 commits March 31, 2025 11:17

Merge branch 'develop' into feature/CXSPA-9722

51daf07

refactor: apply new continuum related test changes.

69f79a9

test: add account settings notification preferences a11y test

cc0577e

uroslates changed the title ~~feat: add Account Settings e2e continuum tets for Email, Password, Personal Details Pages~~ feat: add Account Settings e2e continuum tets for Email, Password, Personal Details, Notifications Pages Apr 1, 2025

uroslates and others added 3 commits April 1, 2025 13:27

Merge branch 'develop' into feature/CXSPA-9722

c80c4f4

refactor: minor test label refactoring

5ae7cea

test: add a11y continuum e2e close account page test

c011a3c

Pio-Bar requested changes Apr 2, 2025

View reviewed changes

uroslates and others added 3 commits April 2, 2025 19:45

Merge branch 'develop' into feature/CXSPA-9722

6550502

fix: address PR comments

d6e63a6

Merge branch 'develop' into feature/CXSPA-9722

438268f

uroslates marked this pull request as ready for review April 3, 2025 21:08

uroslates requested review from a team as code owners April 3, 2025 21:08

uroslates requested a review from Pio-Bar April 7, 2025 12:26

Merge branch 'develop' into feature/CXSPA-9722

ba99fd7

github-actions bot marked this pull request as draft April 7, 2025 12:26

uroslates marked this pull request as ready for review April 7, 2025 12:27

uroslates added 2 commits April 28, 2025 14:38

Merge branch 'develop' into feature/CXSPA-9722

38bc824

Merge branch 'develop' into feature/CXSPA-9722

e3ee772

github-actions bot marked this pull request as draft April 29, 2025 08:03

uroslates marked this pull request as ready for review April 29, 2025 08:06

Zeyber requested changes Apr 29, 2025

View reviewed changes

fix: fixing PR comments

7451b5a

github-actions bot marked this pull request as draft April 29, 2025 10:36

fix: fixing PR comments

4fbc5f5

uroslates marked this pull request as ready for review April 29, 2025 11:20

fix: fixing PR comments

a65ea16

github-actions bot marked this pull request as draft April 29, 2025 11:42

fix: fixing PR lint issues

5a6ede8

uroslates marked this pull request as ready for review April 29, 2025 12:00

Merge branch 'develop' into feature/CXSPA-9722

9f795d8

uroslates requested a review from Zeyber April 29, 2025 13:55

github-actions bot marked this pull request as draft April 29, 2025 13:56

Merge branch 'develop' into feature/CXSPA-9722

5d7716d

uroslates marked this pull request as ready for review April 30, 2025 09:41

github-actions bot marked this pull request as draft April 30, 2025 09:41

uroslates added 2 commits April 30, 2025 14:08

Merge branch 'develop' into feature/CXSPA-9722

1619e9b

Merge branch 'develop' into feature/CXSPA-9722

d928e89

uroslates marked this pull request as ready for review May 5, 2025 13:58

Zeyber requested changes May 6, 2025

View reviewed changes

...frontapp-e2e-cypress/cypress/e2e/accessibility/account-settings-close-account.a11y-e2e.cy.ts Show resolved Hide resolved

fix: fixing PR comments

39158b0

github-actions bot marked this pull request as draft May 6, 2025 08:42

Merge branch 'develop' into feature/CXSPA-9722

07547f9

uroslates requested a review from Zeyber May 6, 2025 08:45

uroslates marked this pull request as ready for review May 6, 2025 08:45

Zeyber approved these changes May 6, 2025

View reviewed changes

uroslates requested a review from Zeyber May 6, 2025 09:12

Zeyber approved these changes May 6, 2025

View reviewed changes

Pio-Bar approved these changes May 6, 2025

View reviewed changes

uroslates merged commit b344de7 into develop May 6, 2025
34 checks passed

uroslates deleted the feature/CXSPA-9722 branch May 6, 2025 10:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add Account Settings e2e continuum tets for Email, Password, Personal Details, Notifications Pages #20126

feat: add Account Settings e2e continuum tets for Email, Password, Personal Details, Notifications Pages #20126

uroslates commented Mar 27, 2025 •

edited

Loading

Pio-Bar left a comment

Pio-Bar Apr 2, 2025

uroslates Apr 3, 2025

Pio-Bar Apr 2, 2025

uroslates Apr 3, 2025

Pio-Bar Apr 2, 2025

uroslates Apr 3, 2025

Pio-Bar Apr 2, 2025

uroslates Apr 3, 2025

Pio-Bar Apr 2, 2025

uroslates Apr 29, 2025

Pio-Bar Apr 2, 2025

uroslates Apr 3, 2025

cypress bot commented Apr 3, 2025 •

edited

Loading

	cy.get('cx-breadcrumb h1').should('contain', 'Close Account');
	cy.get('cx-breadcrumb h1').contains('Close Account');

feat: add Account Settings e2e continuum tets for Email, Password, Personal Details, Notifications Pages #20126

feat: add Account Settings e2e continuum tets for Email, Password, Personal Details, Notifications Pages #20126

Conversation

uroslates commented Mar 27, 2025 • edited Loading

Pio-Bar left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cypress bot commented Apr 3, 2025 • edited Loading

uroslates commented Mar 27, 2025 •

edited

Loading

cypress bot commented Apr 3, 2025 •

edited

Loading