feat: add setting up b2b payment option id #20168
Conversation
| @@ -64,6 +66,7 @@ export class OpfB2bCheckoutPaymentTypeComponent | |||
| protected poNumberInputElement: ElementRef<HTMLInputElement>; | |||
|
|
|||
| protected busy$ = new BehaviorSubject<boolean>(false); | |||
| protected opfPaymentFacade = inject(OpfPaymentFacade); | |||
There was a problem hiding this comment.
Seems like it is not used anywhere
| import { facadeProviders } from './facade/facade-providers'; | ||
|
|
||
| @NgModule({ | ||
| imports: [], | ||
| providers: [...facadeProviders, OpfPaymentConnector], |
There was a problem hiding this comment.
Is OpfPaymentConnector connects with Opf Api, and OpfPaymentOccConnector works with OCC? If yes, can you please add JSdoc to the connectors classes, i think it can be not fully clear especially for person who will look on this for the first time. Maybe it is not worth to add also JSdoc to adapters, so it is clear that it works not with OCC api but with OPF api
There was a problem hiding this comment.
Exactly, good point. Connectors prefixed with OCC connects directly with the OCC endpoints, another one is calling OPF Commerce Cloud Adapter methods.
| }) | ||
| .pipe( | ||
| catchError((error) => { | ||
| throw normalizeHttpError(error, this.logger); |
There was a problem hiding this comment.
@deprecated
since 2211.29 - use tryNormalizeHttpError instead. The normalizeHttpError will be removed from public API together with removing the feature toggle ssrStrictErrorHandlingForHttpAndNgrx.
Closes: CXPA-9706