Skip to content

fix: (CXSPA-9813) Continuum E2Es - Wish List #20185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 22, 2025
Merged

fix: (CXSPA-9813) Continuum E2Es - Wish List #20185

merged 4 commits into from
Apr 22, 2025

Conversation

StanislavSukhanov
Copy link
Contributor

@StanislavSukhanov StanislavSukhanov requested a review from a team as a code owner April 16, 2025 10:04
@github-actions github-actions bot marked this pull request as draft April 16, 2025 10:04
Pio-Bar
Pio-Bar requested changes Apr 17, 2025
View reviewed changes
projects/storefrontapp-e2e-cypress/cypress/e2e/accessibility/wishlist.a11y-e2e.cy.ts Outdated
cy.get('main').a11yRunContinuumTest();
});

it('Add to card', () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add to cart modal has it's own test here: CXSPA-9645
Maybe we should test an empty wishlist instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@StanislavSukhanov StanislavSukhanov marked this pull request as ready for review April 17, 2025 11:33
@github-actions github-actions bot marked this pull request as draft April 17, 2025 11:33
@cypress Cypress
Copy link

cypress bot commented Apr 17, 2025 •
edited
Loading

spartacus    Run #47800

Run Properties:  status check passed Passed #47800  •  git commit 6b6ebacabc ℹ️: Merge c294ae69a623ca94ed84bfec29c5bb8daa3d1264 into 3f2eab5ec8489d14d40cbcd6d07f...
Project spartacus
Branch Review feature/CXSPA-9813-Continuum-E2Es---Wish-List
Run status status check passed Passed #47800
Run duration 04m 59s
Commit git commit 6b6ebacabc ℹ️: Merge c294ae69a623ca94ed84bfec29c5bb8daa3d1264 into 3f2eab5ec8489d14d40cbcd6d07f...
Committer Stanislav Sukhanov
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 3
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 107
View all changes introduced in this branch ↗︎

@StanislavSukhanov StanislavSukhanov marked this pull request as ready for review April 22, 2025 08:48
@StanislavSukhanov StanislavSukhanov merged commit 319cd5c into develop Apr 22, 2025
29 of 30 checks passed
@StanislavSukhanov StanislavSukhanov deleted the feature/CXSPA-9813-Continuum-E2Es---Wish-List branch April 22, 2025 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zeyber Zeyber Zeyber approved these changes

@Pio-Bar Pio-Bar Pio-Bar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@StanislavSukhanov @Zeyber @Pio-Bar