refactor: Update API usage of sax-wasm #567
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
matz3
commented
Feb 25, 2025
matz3
commented
- Updating to the new recommended API of sax-wasm
- Reuse parseXML in xml transpiler
- Updating to the new recommended API of sax-wasm - Reuse parseXML in xml transpiler
codeworrior
reviewed
Feb 25, 2025
| for await (const [event, detail] of saxParser.parse(webContentStream.getReader())) { | ||
| parseHandler(event, detail); | ||
| } | ||
|
|
||
| await finished(contentStream); |
There was a problem hiding this comment.
is finished still required? I would expect that the iterator is exhaustive? The sax-wasm README does not call finished in the ReadableStream example...
BTW: toWeb is still experimental in Node 23 (according to their docs)
There was a problem hiding this comment.
Yeah I guess not but I thought it shouldn't hurt leaving it there. But good point about the experimental API. Then we shouldn't use it, yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.