Fix cleanup-caches workflow for PRs from forks #507
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- .github/workflows/cleanup-caches.yml: change trigger type to pull_request_target which should provide a read-write token. - meaningless change to CMakeLists.txt to activate cmake CI Signed-off-by: Aiden Woodruff <[email protected]>
Signed-off-by: Aiden Woodruff <[email protected]>
|
FYI this should be squashed when it is merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix cleanup-caches workflow for PRs from forks
pull_request_target which should provide a read-write token.
I am pretty sure that this works correctly, but cannot test it effectively because the
cmake.ymlworkflow only runs for PRs which target the develop branch and thepull_request_targetonly runs when the base branch has the changed workflow file.@cwsmith, do we want to merge this and then create a bogus testing PR? Or make a contrived branch with
cmake.ymlwhich runs for PRs which do not target develop, altercleanup-caches.ymlalso, then make a bogus PR which targets that contrived branch, runs thecmake.ymlworkflow, and then close it to confirm it works?Confirmed with https://github.com/SCOREC/core/actions/runs/16089570529 which ran on a PR from a forked branch.