File system api c++: added support for creating temp. files and directories #1706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heinezen
added
improvement
alamt22
force-pushed
the
cpp-temp-file-support
branch
from
1c697a8 to
47e32bc
Compare
alamt22
changed the title
|
@heinezen I think this should be it for the 2 methods. Whenever you're free, let me know if there's anything else I should consider to improve the code. |
|
Thanks, I'll try to review it soon-ish :) |
heinezen
requested changes
Nov 13, 2024
|
Made the requested changes to file.cpp. |
heinezen
previously approved these changes
Nov 18, 2024
|
Fixed the sanity check issues. |
…ectory creation method in directory.cpp
… place a file into it
heinezen
force-pushed
the
cpp-temp-file-support
branch
from
fcb97d8 to
a144c8c
Compare
heinezen
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1540
This is currently a static method in util/path.cpp for creating a temp file, wrapping it in a File object, and returning it. I am planning on doing one for temporary directories later, wrapping it in a Directory object instead. Let me know if you'd like me to wrap both in Path objects instead--I'm not really sure how to do that since Path takes in a fslike shared pointer rather than the file_like one produced by File.