Support Windows for pre-commit hook usage #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #165 +/- ##
==========================================
- Coverage 71.61% 71.42% -0.19%
==========================================
Files 9 9
Lines 546 567 +21
==========================================
+ Hits 391 405 +14
- Misses 155 162 +7
|
This reverts commit 16b6d28.
Change target version to 0.0.0, which should never be an actual version used, meaning there is no single point this test job should suddenly not incur a "change" in the base files.
sygout
approved these changes
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove any OS-specific commands in order to support Windows.
Fixes #160
Several CI test jobs have been added to run all pre-commit hooks in both Linux and Windows environments, furthermore all pytest jobs have been extended to include Windows environments.
The expanded test-space have revealed some weaknesses regarding path-handling, which have been fixed through the usage of
pathlib.PurePosixPath. This ensures the user inputs should still match what is explained in the documentation for paths, namely that one should use POSIX (Linux) type path strings (with forward slashes (/) and excluding drives and similar).Finally, any Linux-specific commands used through
invoke.context.run(), which calls the OS shell, have been removed in favor of a Pythonic approach. Note: It is still necessary that thegitcommand can be run in the given shell where pre-commit is run.