-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to ruff (instead of pylint (and isort)) #192
Merged
Merged
Commits on Oct 9, 2023
-
Update to ruff (instead of pylint (and isort))
Remove pylint as a dependency. Remove all "# pylint: disable=..." statements. Remove pylint and isort as pre-commit hooks. Add ruff as a pre-commit hook. Avoid running pylint in the CI. Add a 'ruff' CI job. Add (back) disable E501 statements. E501: Line too long. Add it for either lines with string-formatted type (which has to be on one line) or an f-string with a single variable (i.e., a single-line f-string part with an implemented logic for a variable that results in the line being too long).
Configuration menu - View commit details
-
Copy full SHA for cd41192 - Browse repository at this point
Copy the full SHA cd41192View commit details
Commits on Oct 16, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 7e50658 - Browse repository at this point
Copy the full SHA 7e50658View commit details
Commits on Oct 23, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 97965e2 - Browse repository at this point
Copy the full SHA 97965e2View commit details
Commits on Oct 25, 2023
-
Configuration menu - View commit details
-
Copy full SHA for b47d72a - Browse repository at this point
Copy the full SHA b47d72aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4727377 - Browse repository at this point
Copy the full SHA 4727377View commit details -
Extend arguments to ruff CLI, ensuring no unsafe fixes are made and any fixes are shown explicitly in the output.
Configuration menu - View commit details
-
Copy full SHA for 0555740 - Browse repository at this point
Copy the full SHA 0555740View commit details -
Split ruff jobs according to (non-)code base
Extend rule set for job on code base to include flake8-blind-except and pylint. Ignore self assignment of variable rule. Ignore all too-many-* rules from pylint, because we will extend the recommended number of branches, statements, function args, etc. in this code base. Otherwise, run with a rule set that includes pycodestyle, pyflakes, pyupgrade, flake8-bugbear, flake8-simplify, isort, and ruff.
Configuration menu - View commit details
-
Copy full SHA for 1d83102 - Browse repository at this point
Copy the full SHA 1d83102View commit details -
Configuration menu - View commit details
-
Copy full SHA for 18a8bae - Browse repository at this point
Copy the full SHA 18a8baeView commit details -
Configuration menu - View commit details
-
Copy full SHA for ee89b67 - Browse repository at this point
Copy the full SHA ee89b67View commit details
Commits on Oct 27, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 08591d7 - Browse repository at this point
Copy the full SHA 08591d7View commit details
Commits on Nov 1, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 7f639c2 - Browse repository at this point
Copy the full SHA 7f639c2View commit details
Commits on Nov 10, 2023
-
Merge remote-tracking branch 'origin/main' into cwa/close-191-use-ruff
Also: - Remove pyupgrade (UP) rule for ruff. An actual pyupgrade hook should be used instead. - Remove bandit (S) rule for ruff hooks for core code base. The bandit hook takes care of these. - Update hook versions. - Switch hook activation order; run black before ruff. - Add python_version-specific pre-commit version in the 'dev' extra. - Add a typing.NamedTuple for an ignore entry pair. This is used to minimize mypy ignore statements.
Configuration menu - View commit details
-
Copy full SHA for 265a98a - Browse repository at this point
Copy the full SHA 265a98aView commit details -
Enforce importing __future__.annotations in all Python files. Update code accordingly.
Configuration menu - View commit details
-
Copy full SHA for b454e3a - Browse repository at this point
Copy the full SHA b454e3aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9b4b175 - Browse repository at this point
Copy the full SHA 9b4b175View commit details
Commits on Nov 22, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 7377032 - Browse repository at this point
Copy the full SHA 7377032View commit details -
Update ruff rules to match scientific-python
Or rather, base it on scientific-python and then update it to fit this package. Update the code base accordingly.
Configuration menu - View commit details
-
Copy full SHA for b087615 - Browse repository at this point
Copy the full SHA b087615View commit details
Commits on Dec 6, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 3242819 - Browse repository at this point
Copy the full SHA 3242819View commit details
Commits on Dec 7, 2023
-
Configuration menu - View commit details
-
Copy full SHA for da5cfa6 - Browse repository at this point
Copy the full SHA da5cfa6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5c3f49e - Browse repository at this point
Copy the full SHA 5c3f49eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 182dbb9 - Browse repository at this point
Copy the full SHA 182dbb9View commit details -
Configuration menu - View commit details
-
Copy full SHA for c886a27 - Browse repository at this point
Copy the full SHA c886a27View commit details -
Configuration menu - View commit details
-
Copy full SHA for 40d3a23 - Browse repository at this point
Copy the full SHA 40d3a23View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.