Fix double free in test_collection

SINTEF · Nov 6, 2024 · 89dceb5 · 89dceb5
1 parent 123798d
commit 89dceb5
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/src/dlite-collection.c b/src/dlite-collection.c
@@ -45,8 +45,8 @@ int dlite_collection_deinit(DLiteInstance *inst)
   while ((r=dlite_collection_find(coll,&state, NULL, "_has-uuid", NULL,
                                   NULL))) {
     if ((inst2 = dlite_instance_get(r->o))) {
-      dlite_instance_decref(inst2);
-      dlite_instance_decref(inst2);
+      dlite_instance_decref(inst2);  // remove ref from collection
+      dlite_instance_decref(inst2);  // remove local ref to inst2
     } else {
       warnx("cannot remove missing instance: %s", r->o);
     }

diff --git a/src/tests/test_collection.c b/src/tests/test_collection.c
@@ -263,7 +263,6 @@ MU_TEST(test_collection_load)
   //dlite_json_print((DLiteInstance *)inst);
   //printf("----------------------\n");
 
-  dlite_instance_decref((DLiteInstance *)inst);
   dlite_collection_decref(coll2);
 }