Skip to content

Commit

Permalink
Move sdist files correctly (#857)
Browse files Browse the repository at this point in the history
sdist folder has 5 underscrores because all sdist artifacts are named with 5 underscores and variables inbetween


## Type of change
- [x] Bug fix & code cleanup
- [ ] New feature
- [ ] Documentation update
- [ ] Test update

## Checklist for the reviewer
This checklist should be used as a help for the reviewer.

- [ ] Is the change limited to one issue?
- [ ] Does this PR close the issue?
- [ ] Is the code easy to read and understand?
- [ ] Do all new feature have an accompanying new test?
- [ ] Has the documentation been updated as necessary?
  • Loading branch information
francescalb authored Jun 21, 2024
2 parents 6753202 + ec73667 commit ddedf77
Showing 1 changed file with 4 additions and 5 deletions.
9 changes: 4 additions & 5 deletions .github/workflows/cd_release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -226,6 +226,7 @@ jobs:
- name: Store sdist for publishing
uses: actions/upload-artifact@v4
with:
# Note that they are moved to a common directory sdist_____ (5 underscores, as in the name below)
name: sdist_${{ matrix.os }}_${{ matrix.system_type[0] }}_${{ matrix.system_type[1] }}_${{ matrix.arch }}_${{ matrix.py_minors }}
path: python/dist/*

Expand All @@ -240,13 +241,11 @@ jobs:
with:
path: dist

- name: Move wheels and sdist files to dist/
- name: Move sdist files to dist/m wheel files already there
run: |
ls -lah dist
mv dist/wheelhouse/* dist/
mv dist/sdist/* dist/
rm -rf dist/wheelhouse
rm -rf dist/sdist
mv dist/sdist_____/* dist/
rm -rf dist/sdist_____
ls -lah dist
# - name: Publish package to Test PyPI
Expand Down

0 comments on commit ddedf77

Please sign in to comment.