Unit tests #17
Closed
Unit tests #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, update pre-commit hooks.
Codecov Report
@@ Coverage Diff @@
## main #17 +/- ##
=======================================
Coverage ? 16.02%
=======================================
Files ? 12
Lines ? 387
Branches ? 0
=======================================
Hits ? 62
Misses ? 325
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. |
Try to implement dynamic signature generation!
|
The work on this has opened my eyes to the fact that the various parts of this repository really should be looked at again, possibly with a new approach to what it should actually contain - and do. |
|
Closing as these changes are either already implemented through other PRs or are outdated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11
Closes #2
Add unit tests using the pytest framework.
The tests are run through a new CI job, which also uploads a code coverage report to codecov.io, see app.codecov.io/gh/SINTEF/soft7.
As a minimum, before making this PR ready for review, I want some basic unit tests for:
When tests for
dataspace_factory.pyhave been put in place, issue #15 can be addressed, and it should be immediately apparent if any changes introduce a degradation of the expected behaviour.