[feat/#76] products api 연동 및 더보기 버튼 핸들러 추가 #90
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ 빌드에 성공했습니다! 🎉 |
heesunee
reviewed
May 21, 2025
src/pages/home/Home.tsx
Outdated
Comment on lines
25
to
27
| const searchedList = useMemo(() => { | ||
| return productListData?.productMainInfos ?? []; | ||
| }, [productListData]); |
There was a problem hiding this comment.
단순한 값이라 불필요하지 않을까 했는데, 사용하신 기준이 궁금합니다
src/pages/home/Home.tsx
Outdated
| /> | ||
| ))} | ||
| </div> | ||
| {!isProductListLoading && !isProductListError && ( |
There was a problem hiding this comment.
Loading이랑 error일때 렌더링 처리도 고려하면 더 좋을 것 같아요!
Comment on lines
+34
to
+36
| const handleShowMore = () => { | ||
| setVisibleCount(prev => prev + 9); | ||
| }; |
Comment on lines
14
to
19
| useEffect(() => { | ||
| if (!isLoading) { | ||
| const filtered = productList.filter(card => card.categoryList.includes(selectedTag)); | ||
| setFilteredCards(filtered); | ||
| } | ||
| }, [productList, selectedTag, isLoading]); |
There was a problem hiding this comment.
선택된 태그와 리스트에 따라 필터링된 데이터를 상태로 관리하는 로직인가요? filteredCards는 이미 productList와 selectedTag에서 계산된 결과라, 별도의 상태가 아닌 렌더링 시점에 계산하는게 직관적인 것 같은데 useEffect에 추가적인 state값으로 작성하신 이유가 있나요? 동일한 값에 대해 계속해서 필터링 함수를 적용해야 한다면 오히려 useMemo도 사용해 볼 수 있을것 같아요.
|
✅ 빌드에 성공했습니다! 🎉 |
|
✅ 빌드에 성공했습니다! 🎉 |
|
✅ 빌드에 성공했습니다! 🎉 |
jeonghoon11
reviewed
May 22, 2025
src/pages/home/Home.tsx
Outdated
| @@ -6,13 +7,90 @@ import Banner from '@/../public/img/banner_familymonth.png'; | |||
| import Tag from '@/pages/home/components/Tag'; | |||
| import Text from '@shared/components/text/Text'; | |||
| import Card from '@shared/components/card/Card'; | |||
| import CardSkeleton from '@shared/components/card/CardSkeleton'; | |||
| import ProductActionButton from '@shared/components/ProductActionButton/ProductActionButton'; | |||
| import { useGetProductList } from '@api/queries'; | |||
| import { dummyCardsL } from '@/pages/home/mockHomeData'; | |||
Comment on lines
+34
to
+36
| const handleShowMore = () => { | ||
| setVisibleCount(prev => prev + 9); | ||
| }; |
jeonghoon11
approved these changes
May 22, 2025
|
✅ 빌드에 성공했습니다! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Related Issues
✅ 체크 리스트
📄 Tasks
⭐ PR Point (To Reviewer)
📷 Screenshot
🔔 ETC