-
Notifications
You must be signed in to change notification settings - Fork 3
[feat/#92] 검색 페이지에 useDebounce 적용 및 세부 페이지로 이동 시 검색어 초기화 X #93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ 빌드에 성공했습니다! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고하셨습니다!
예를 들어 6개 이상일 시에만 더보기 버튼 보이게 하는 것도 좋을 것 같아요!
✅ 빌드에 성공했습니다! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨습니다!! 제가 보기엔 깔끔한데요??
검색하고 항목2개 떴을때 layout만 다시 잡으면 벌써 최고네요 고생하셨습니다!
src/shared/hooks/useDebounce.ts
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
깔끔한데요???
다음 작업들은 #96 로 이어서 진행할 예정입니다! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
경로만 상수로 바꿔주면 될거 같아요! 검색의 권위자 짱짱겅 지우 최고 🥰🥰❤️
|
||
const Header = () => { | ||
const navigate = useNavigate(); | ||
const location = useLocation(); | ||
const isSearchPage = location.pathname === '/products'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이거 경로 route 에 있는 상수로 바꿉시다!
@@ -25,7 +30,16 @@ const Header = () => { | |||
}, []); | |||
|
|||
useEffect(() => { | |||
if (location.pathname !== '/products') { | |||
if (isSearchPage) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
여기도 마찬가지!
✅ 빌드에 성공했습니다! 🎉 |
📌 Related Issues
✅ 체크 리스트
📄 Tasks
⭐ PR Point (To Reviewer)
📷 Screenshot
usedebounce_zuzgAe0z.mp4
🔔 ETC