Skip to content

1050 add smooth seeking and thumbnail preview to PillarboxMediaController #1081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
Jul 9, 2025
Merged

1050 add smooth seeking and thumbnail preview to PillarboxMediaController #1081

merged 21 commits into from
Jul 9, 2025

Conversation

StaehliJ
Copy link
Contributor

Pull request

Description

This PR adds some feature that was previously only supported when using PillarboxExoPlayer.

Changes made

  • Add set/get SeekParameters to the base interface PillarboxPlayer.
  • Add PillarboxPlayer.setImageOutput

Checklist

  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).

@StaehliJ StaehliJ linked an issue Jun 26, 2025 that may be closed by this pull request
Investigate SmoothProgressTrackerState usable with a PillarboxMediaController #1050
Closed
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Pillarbox Jun 26, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 26, 2025 •
edited
Loading

Code Coverage

Overall Project 49.07% -3.01% 🟢
Files changed 1% 🟢

Module Coverage
:pillarbox-player 54.41% -5.57% 🟢
:pillarbox-cast 8.52% -0.97% 🟢
:pillarbox-ui 0.26% -0.88% 🟢
Files
Module File Coverage
:pillarbox-player PillarboxExoPlayer.kt 71.53% 🟢
PillarboxPlayer.kt 0% 🟢
PillarboxSessionCommands.kt 0% -57.98% 🟢
PillarboxMediaController.kt 0% -11.82% 🟢
PillarboxMediaSession.kt 0% -39.25% 🟢
MediaSessionCallbackImpl.kt 0% 🟢
:pillarbox-cast PillarboxCastPlayer.kt 0% -1.94% 🟢
:pillarbox-ui SmoothProgressTrackerState.kt 0% -21.36% 🟢

@StaehliJ StaehliJ force-pushed the 1050-investigate-smoothprogresstrackerstate-usable-with-a-pillarboxmediacontroller branch from 762fd77 to 89238e2 Compare June 26, 2025 13:55
@StaehliJ StaehliJ marked this pull request as ready for review June 26, 2025 13:57
MGaetan89
MGaetan89 reviewed Jun 27, 2025
View reviewed changes
@StaehliJ StaehliJ requested a review from MGaetan89 July 2, 2025 14:24
MGaetan89
MGaetan89 reviewed Jul 3, 2025
View reviewed changes
Copy link
Member

@MGaetan89 MGaetan89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some unresolved/unanswered comments:

@StaehliJ StaehliJ moved this from 📋 Backlog to 🍿 Code Review in Pillarbox Jul 8, 2025
@StaehliJ StaehliJ mentioned this pull request Jul 8, 2025
Closed
@MGaetan89 MGaetan89 added this pull request to the merge queue Jul 9, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 9, 2025
@MGaetan89 MGaetan89 added this pull request to the merge queue Jul 9, 2025
Merged via the queue into main with commit aedd597 Jul 9, 2025
10 checks passed
@MGaetan89 MGaetan89 deleted the 1050-investigate-smoothprogresstrackerstate-usable-with-a-pillarboxmediacontroller branch July 9, 2025 07:33
@github-project-automation github-project-automation bot moved this from 🍿 Code Review to ✅ Done in Pillarbox Jul 9, 2025
@MGaetan89 MGaetan89 mentioned this pull request Jul 16, 2025
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGaetan89 MGaetan89 MGaetan89 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Pillarbox
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Investigate SmoothProgressTrackerState usable with a PillarboxMediaController
2 participants
@StaehliJ @MGaetan89