Skip to content

Display artwork image #1103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jul 16, 2025
Merged

Display artwork image #1103

merged 8 commits into from
Jul 16, 2025

Conversation

StaehliJ
Copy link
Contributor

@StaehliJ StaehliJ commented Jul 9, 2025

Pull request

Description

This PR adds the artwork image of a media item when video track has been disabled or there is no video track. Video track and image track is treated the same.

Changes made

  • Add artwork image to PlayerView in the mobile and tv demo

Checklist

  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).

@github-project-automation github-project-automation bot moved this to 📋 Backlog in Pillarbox Jul 9, 2025
@StaehliJ StaehliJ linked an issue Jul 9, 2025 that may be closed by this pull request
Display artwork image when there is no video #1097
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 9, 2025 •
edited
Loading

Code Coverage

Overall Project 48.8% -0.28% 🟢
Files changed 0% 🟢

Module Coverage
:pillarbox-player 54.27% -0.3% 🟢
:pillarbox-ui 0.26% -0.81% 🟢
Files
Module File Coverage
:pillarbox-player PlayerCallbackFlow.kt 67.91% -3.23% 🟢
:pillarbox-ui ComposablePlayer.kt 0% -3.74% 🟢

@MGaetan89 MGaetan89 self-requested a review July 10, 2025 12:29
@MGaetan89
Copy link
Member

When the metrics overlay is enabled, the artwork is displayed on top of the metrics:
Screenshot_20250710_143252

@StaehliJ StaehliJ requested a review from MGaetan89 July 16, 2025 07:40
@MGaetan89 MGaetan89 added this pull request to the merge queue Jul 16, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 16, 2025
@MGaetan89 MGaetan89 added this pull request to the merge queue Jul 16, 2025
Merged via the queue into main with commit 4bc13c1 Jul 16, 2025
10 checks passed
@MGaetan89 MGaetan89 deleted the display-artwork-image branch July 16, 2025 15:57
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Pillarbox Jul 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGaetan89 MGaetan89 MGaetan89 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Pillarbox
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Display artwork image when there is no video
2 participants
@StaehliJ @MGaetan89