Only set listeners when there are senders connected#1104
Closed
MGaetan89 wants to merge 1 commit into928-custom-castplayerfrom
Closed
Only set listeners when there are senders connected#1104MGaetan89 wants to merge 1 commit into928-custom-castplayerfrom
MGaetan89 wants to merge 1 commit into928-custom-castplayerfrom
Conversation
Code Coverage
Files
|
StaehliJ
requested changes
Jul 15, 2025
Contributor
StaehliJ
left a comment
There was a problem hiding this comment.
I don't see where the benefits are. And what happens when something is already playing and then the first sender connect? I think some of the mediaStatusModifier that are done in some player events won't be update. So at least a first synchronization has to happen first when adding the listener don't you think?
Contributor
Author
|
As we discussed, it might be overengineered to try to address this right now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request
Description
This PR updates
PillarboxCastReceiverPlayerto only set listeners when there are senders connected.Changes made
Checklist