Skip to content

Fix aspect ratio when navigating between different media type #1106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 14, 2025
Merged

Fix aspect ratio when navigating between different media type #1106

merged 1 commit into from
Jul 14, 2025

Conversation

MGaetan89
Copy link
Member

Pull request

Description

This PR fixes the wrong aspect ratio when switching between different media types (video/audio).

Changes made

  • Use a state to access the current media tracks in the PlayerSurface.
  • Take the image track into consideration when deciding the aspect ratio in PlayerSurface.
  • Fix some Dependency Analysis warnings.

Checklist

  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).

@MGaetan89 MGaetan89 self-assigned this Jul 11, 2025
@MGaetan89 MGaetan89 linked an issue Jul 11, 2025 that may be closed by this pull request
Fix broken video aspect ratio when switching between different media types (audio/video/image) #1105
Closed
1 task
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Pillarbox Jul 11, 2025
@github-actions GitHub Actions
Copy link

Code Coverage

Overall Project 48.9% -0.19% 🟢
Files changed 0% 🟢

Module Coverage
:pillarbox-ui 0.26% -1.27% 🟢
Files
Module File Coverage
:pillarbox-ui PlayerSurface.kt 1.29% -6.34% 🟢

@MGaetan89 MGaetan89 marked this pull request as ready for review July 11, 2025 09:19
@MGaetan89 MGaetan89 requested a review from StaehliJ July 11, 2025 09:19
@StaehliJ StaehliJ added this pull request to the merge queue Jul 14, 2025
Merged via the queue into main with commit ea0b5b4 Jul 14, 2025
16 of 17 checks passed
@StaehliJ StaehliJ deleted the 1105-fix-broken-video-aspect-ratio-when-switching-between-different-media-types-audiovideoimage branch July 14, 2025 14:00
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Pillarbox Jul 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StaehliJ StaehliJ StaehliJ approved these changes

Assignees

@MGaetan89 MGaetan89

Labels
None yet
Projects
Pillarbox
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix broken video aspect ratio when switching between different media types (audio/video/image)
2 participants
@MGaetan89 @StaehliJ