🐛 Mobile | Fix camera toggle freezing the app #1372
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…with semaphore and enhance async handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1374
There seems to be an issue with the camera library on iOS where toggling the CameraEnabled value too quickly after the value was previously changed can cause the entire app to lock up for several seconds. One way to reproduce this is by going to the scanner, tapping My Code, tapping Scan and then soon after tapping one of the tabs at the bottom of the screen.
This change updates this toggling code to prevent this value from changing too quickly by adding a delay, which appears to resolve this issue.
No