feat: GeekNews 명령어 기능 추가 #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/엇 요거 server_palette 말고 playground_palette에 넣어주세요. |
|
아하 playground_palette로 옮기도록 하겠습니다 |
choo121600
requested changes
Apr 2, 2025
Comment on lines
52
to
60
| @slash_command(guild_ids=GUILD_ID, description="저장된 뉴스 링크를 모두 삭제합니다.") | ||
| async def news_rm(self, ctx): | ||
| if ctx.channel.id != CHANNEL_ID_ALLOWED: | ||
| await ctx.respond("이 명령어는 지정된 채널에서만 사용 가능합니다.", ephemeral=True) | ||
| return | ||
|
|
||
| cursor.execute("DELETE FROM news") | ||
| conn.commit() | ||
| await ctx.respond("저장된 뉴스 링크가 모두 삭제되었습니다.") |
There was a problem hiding this comment.
현재 데이터의 삭제를 맡는 news_rm의 @slash_command에 별도의 권한 제한이 설정되어 있지 않습니다.
@commands.has_any_role("역할 명")을 활용하여 특정 역할을 가진 사용자만 실행할 수 있도록 제한하는 것이 필요합니다.
There was a problem hiding this comment.
확인했습니다. 지금은 CHANNEL_ID_ALLOWED 로 특정채널에서만 가능하도록 해놨는데, 해당부분을 지우고 권한 방식으로 변경하겠습니다
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GeekNews 관리자 (
cogs/playground_palette/news_manager.py)/news_add <url>/news_list/news_rm