Extract common logic out of the build operation #233
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves all the configuration logic, that was previously defined in the build operation, under a new package called
config.This is done, to increase testability and reusability of the code and is actually the first step needed in making the
customizecommand work with the configuration directory.Notable changes to the code:
action/build.goand into a newconfig.Parse()function.Buildernow directly works with the configuration manager and no longer handles the configuration part.image.Configurationas opposed to shipping the fullimage.Definitionwithout actually needing it.This PR is ready for review, but will stay in "Draft", as it needs to rebase and include the changes coming from the following PRs:
It makes more sense to rebase the changes here, as it will be more destructive if this PR needs to be rebased onto the aforementioned ones.