Fix deployment merge logic #244
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit considers the case where the destination slice is longer than the source slice. Former logic omitted this particular case, which resulted in truncating the destination slice to the length of source slice. Signed-off-by: David Cassany <[email protected]>
Contributor
|
Hey @davidcassany, I was also working on fixing this and some other merge logic problems. A PR for which will be opened later today. Apologies for not communicating this with you. Would it be reasonable to wait a couple of hours for my PR to land so then we can reevaluate the logic changes that both PRs introduce and pick an approach? That way we would not have to possibly merge something that will change with the next PR iteration. If this is urgent and can't be postponed for a couple of hours I am fine to merge it and they see how that reflects in my PR. Eitherway, let me know what you think. P.S.: The mentioned PR - #248. Let me know what you think. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit considers the case where the destination slice is longer than the source slice. Former logic omitted this particular case, which resulted in truncating the destination slice to the length of source slice.