Add --log-file global CLI flag #246
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atanasdinov
reviewed
Nov 19, 2025
Contributor
atanasdinov
left a comment
atanasdinov
left a comment
There was a problem hiding this comment.
This is great, one minor comment but happy to approve otherwise!
The --log-file flag takes a string that can be a path to a file or -/stdout/stderr and sets the log target. Signed-off-by: Fredrik Lönnegren <[email protected]>
atanasdinov
reviewed
Nov 19, 2025
| } | ||
|
|
||
| func Teardown(ctx *cli.Context) error { | ||
| return logFile.Close() |
Contributor
There was a problem hiding this comment.
This is going to panic with nil dereference in the cases where we don't log to file. Perhaps a single if logFile != nil first should be enough?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The --log-file flag takes a string that can be a path to a file or
-/stdout/stderr and sets the log target.
Signed-off-by: Fredrik Lönnegren [email protected]