Fix unpack-image command #249
Open
+8
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Loic Devulder <[email protected]>
ldevulder
commented
Nov 19, 2025
| unpacker := &OCI{ | ||
| s: s, | ||
| verify: true, | ||
| platformRef: s.Platform().String(), |
Member
Author
There was a problem hiding this comment.
I think this line was here to set the value to the host platform by default, but it doesn't work. And anyway having it defined in the cli/cmd side is better IMO and we can see the default value with an elemental3ctl unpack-image --help.
ldevulder
commented
Nov 19, 2025
| func NewOCIUnpacker(s *sys.System, imageRef string, opts ...OCIOpt) *OCI { | ||
| unpacker := &OCI{ | ||
| s: s, | ||
| verify: true, |
Member
Author
There was a problem hiding this comment.
The verify value is already set here to the default value true.
Member
Author
|
It seems that the PR broke something, I think I know why, will fix it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
unpack-imagecommand fails like this:It works if I set
--platform linux/amd64but I think that this should be set to the host architecture by default (it still can be forced to something else with-platform).