-
Notifications
You must be signed in to change notification settings - Fork 7
Store required patches in codestream object #170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
vmezzela
wants to merge
11
commits into
SUSE:devel
Choose a base branch
from
vmezzela:filter-patches
base: devel
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
required by sys.exit() Signed-off-by: Vincenzo Mezzela <[email protected]>
Signed-off-by: Vincenzo Mezzela <[email protected]>
Signed-off-by: Vincenzo Mezzela <[email protected]>
Signed-off-by: Vincenzo Mezzela <[email protected]>
Signed-off-by: Vincenzo Mezzela <[email protected]>
Signed-off-by: Vincenzo Mezzela <[email protected]>
fgyanz
reviewed
Nov 12, 2025
Collaborator
fgyanz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool @vmezzela !! I like the changes, just some minor comments.
In this way, if no patches are supplied, all the codestreams will go in the unaffected_codestreams list Signed-off-by: Vincenzo Mezzela <[email protected]>
Signed-off-by: Vincenzo Mezzela <[email protected]>
Signed-off-by: Vincenzo Mezzela <[email protected]>
Signed-off-by: Vincenzo Mezzela <[email protected]>
2b96161 to
ed83cde
Compare
Collaborator
Author
|
@fgyanz comments addressed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an initial reorganization of the code around
scanand the way we store the patches in preparation for fixing #153 .The final fix can be implemented only after #160 is merged since that PR drops the use of quilt to apply the patches, which makes it more easy to selectively apply them.
I took the chance to further refactor
scan. What was done before is:get_patched_kernels())The unnecessary thing was that we were storing the
cs.kernelinpatched_kernelswhen filtering withget_patched_kernels(). And then afterward we were checking which codestreams had that kernel withif cs.kernel in patched_kernels. This has been simplified by just filtering the patched codestreams (rather than their kernel). With this, a whole loop has been dropped because unneeded.Now the process is:
Avoiding the unneeded
patched_kernel.add(cs.kernel)and thencs->cs.kernel->if cs.kernel in patched_cs->patched_cs.append(cs)steps.Besides that, the most notable part is that now the required patches are stored in the codestream object directly, so that we can just retrieve the patches from there on a per codestream basis rather than on a per product basis, effectively introducing the possibility to perform the patch analysis only on those that are needed. And same goes for the extraction where we will be able to apply only the needed ones.
This is yet to be tested. I am posting this PR in advance to help coordinate the work across different PRs.