ENHANCED: Added 'c_cxx' flag and env SWIPL_CXX for packs #1293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamahen
commented
Jul 5, 2024
| @@ -49,7 +49,7 @@ if(CMAKE_COMPILER_IS_GNUCC) | |||
| set(GCC_OPTFLAGS -O2) | |||
| endif() | |||
|
|
|||
| set(CMAKE_C_FLAGS_DEBUG "-DO_DEBUG -DO_DEBUG_ATOMGC -O0 ${GCC_GFLAGS} $ENV{CFLAGS}" | |||
| set(CMAKE_C_FLAGS_DEBUG "-DO_DEBUG -DO_DEBUG_ATOMGC -O0 ${GCC_GFLAGS} $ENV{CFLAGS} -DO_CHECK_TERM_REFS -DSECURE_GC -DCHK_SECURE -DO_MAINTENANCE -gdwarf-2 -g3" | |||
There was a problem hiding this comment.
You might not agree with this change -- but it has the flags that caused #1292 when doing a debug build.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
| preferred_c_compiler(gcc). | ||
| preferred_c_compiler(clang). | ||
| preferred_c_compiler(cc). | ||
| preferred_c_compiler(path(gcc)). |
There was a problem hiding this comment.
I could find no good reason for the path() wrapper. has_program/2 adds this if necessary. If this fixes some issue I think it is has_program/2 that needs fixing. So, I skipped this.
There was a problem hiding this comment.
Line 521 (program_install_prefix/1) has has_program(path(Name), EXE), ... is it wrong?
has_program/2 uses pack_build_path(...), not path(...) ... presumably the former is better?
|
Applied after the mentioned changes and some documentation changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did a quick check of
buildenv.shwhen I didpack_install(.)for a pack and it appears to be correct --SWIPL_CXX='g++'was added.