Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor : party leader -> manager로 네이밍 변경 및 party event에 distance 추가 #53

Merged
merged 4 commits into from
Sep 22, 2023

Conversation

phjppo0918
Copy link
Member

개요

party leader를 manager로 네이밍을 변경하였습니다.
또한 클라이언트 요구에 따라 event에 distance를 추가하였습니다.

@phjppo0918 phjppo0918 self-assigned this Sep 22, 2023
@phjppo0918 phjppo0918 added the ♻️ 리팩토링 기존 코드를 리팩토링한다. label Sep 22, 2023
@github-actions
Copy link

github-actions bot commented Sep 22, 2023

Unit Test Results

75 tests   75 ✔️  5s ⏱️
29 suites    0 💤
29 files      0

Results for commit a543572.

♻️ This comment has been updated with latest results.

@@ -5,8 +5,13 @@

import java.util.List;

public record PartyEvent(String entryCode, String leaderId, PartyStatus status, List<String> participants, String battleId) {
public record PartyEvent(String entryCode,
int distance, String leaderId,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leaderId네요

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

반영했어요!

@sonarcloud
Copy link

sonarcloud bot commented Sep 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@phjppo0918 phjppo0918 merged commit cb3f37a into develop Sep 22, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
♻️ 리팩토링 기존 코드를 리팩토링한다.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants