DHP-969 Batch Export Participant Worker & DHP-970 Tune Worker Thread Pool #175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DwayneJengSage
commented
Jul 30, 2023
src/main/java/org/sagebionetworks/bridge/exporter3/BaseParticipantVersionWorkerProcessor.java
Outdated
Show resolved
Hide resolved
src/main/java/org/sagebionetworks/bridge/exporter3/BaseParticipantVersionWorkerProcessor.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Pull Request Overview
This PR refactors several worker processors and their test suites for participant version export, while also updating configuration values and introducing a common base request and processor class to reduce duplicated logic. Key changes include:
- Consolidation of request classes with a common base (BaseParticipantVersionRequest)
- Updated thread pool and rate limiter configurations in the resources and Spring configuration files
- Refactoring of Redrive, Ex3, and BatchExport worker processors to extend a common base class
Reviewed Changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/test/java/org/sagebionetworks/bridge/exporter3/RedriveParticipantVersionsWorkerProcessorTest.java | Adjustments in test setup and removal of legacy mocking/testing code |
| src/test/java/org/sagebionetworks/bridge/exporter3/BatchExportParticipantVersionWorkerProcessorTest.java | New test suite for batch export functionality |
| src/main/resources/BridgeWorkerPlatform.conf | Updates to thread pool sizes and Synapse rate limits |
| src/main/java/org/sagebionetworks/bridge/workerPlatform/config/SpringConfig.java | Added bean for append table executor service |
| src/main/java/org/sagebionetworks/bridge/exporter3/* | Refactoring of various worker processors to inherit common behavior via a base class |
| // Mock shared dependencies. | ||
| Config mockConfig = mock(Config.class); | ||
| when(mockConfig.get(RedriveParticipantVersionsWorkerProcessor.CONFIG_KEY_BACKFILL_BUCKET)).thenReturn( | ||
| BACKFILL_BUCKET); | ||
| processor.setConfig(mockConfig); | ||
|
|
||
| app = Exporter3TestUtil.makeAppWithEx3Config(); | ||
| App app = Exporter3TestUtil.makeAppWithEx3Config(); |
There was a problem hiding this comment.
Consider assigning to the class-level 'app' field instead of declaring a new local variable so that later tests that rely on 'app' are not affected by variable shadowing.
Suggested change
| App app = Exporter3TestUtil.makeAppWithEx3Config(); | |
| app = Exporter3TestUtil.makeAppWithEx3Config(); |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress
https://sagebionetworks.jira.com/browse/DHP-969
https://sagebionetworks.jira.com/browse/DHP-970