Move dev script to a bash script, allow compiling for Firefox in #5461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PortalDebug module, move sass compilation to process-resources to ensure it is reliably copied in the compile step
nickgros
commented
Jul 19, 2024
| @@ -370,7 +370,7 @@ | |||
| src/main/webapp/sass:src/main/webapp/generated | |||
| </arguments> | |||
| </configuration> | |||
| <phase>compile</phase> | |||
| <phase>process-resources</phase> | |||
There was a problem hiding this comment.
Move sass compilation to process-resources to ensure the static resources created by this job are copied, which happens in the compile step
nickgros
commented
Jul 19, 2024
| @@ -2,5 +2,5 @@ | |||
| <module rename-to='Portal'> | |||
| <inherits name="org.sagebionetworks.web.Portal" /> | |||
|
|
|||
| <set-property name="user.agent" value="safari" /> | |||
| <set-property name="user.agent" value="safari,gecko1_8" /> | |||
There was a problem hiding this comment.
allow using firefox with PortalDebug module. If you have precompile off, it won't compile the gecko1_8 permutation unless you actually load the app in devmode with the expected user agent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PortalDebug module, move sass compilation to process-resources to ensure it is reliably copied in the compile step