PORTALS-3651: Portals FileEntity Page: Header card #2024
Conversation
apps/synapse-portal-framework/src/pages/FileEntityPage/FileEntityPageHeader.tsx
Outdated
Show resolved
Hide resolved
packages/synapse-react-client/src/components/CitationPopover/CitationPopover.tsx
Outdated
Show resolved
Hide resolved
apps/synapse-portal-framework/src/pages/FileEntityPage/FileEntityPage.tsx
Outdated
Show resolved
Hide resolved
| <DetailsPageLayout> | ||
| <DetailsPageMenu menuSections={fileEntityPageSections} /> |
There was a problem hiding this comment.
Taking a look at these again since your last refactor, and I think it might be slightly cleaner to use the DetailsPageContent component and pass it a list of sections. It will render the menu and section headers for you, and ensure the style is more consistent with existing details pages.
Or will we need more customization than that component provides?
I will let Adam know about the font size and spacing differences |
| @@ -24,6 +24,10 @@ const DetailsPageMenu = ({ | |||
| } | |||
| } | |||
|
|
|||
| const filteredMenuSections = menuSections.filter( | |||
There was a problem hiding this comment.
I need a component in here alongside the other sections without it actually showing up as an option in the menu (SynapseFileEntityLinkCard)
There was a problem hiding this comment.
Do all of our existing details page sections have a truthy id and title? If so, then this works
| @@ -24,6 +24,10 @@ const DetailsPageMenu = ({ | |||
| } | |||
| } | |||
|
|
|||
| const filteredMenuSections = menuSections.filter( | |||
There was a problem hiding this comment.
Do all of our existing details page sections have a truthy id and title? If so, then this works
| import DetailsPageLayout from '@/components/DetailsPageLayout' | ||
| import HeaderCard from 'synapse-react-client/components/HeaderCard' | ||
| import CitationPopover from 'synapse-react-client/components/CitationPopover' | ||
| import { DetailsPageContent } from '../../components/DetailsPage/DetailsPageContentLayout' | ||
| import SynapseFileEntityLinkCard from './SynapseFileEntityLinkCard' | ||
|
|
||
| function FileEntityPage() { |
There was a problem hiding this comment.
If we need to change the styles (but not the layout/DOM) of the header card, e.g. to give the title a different font size, we could apply styles to this component that target those elements.
…er from fileentitypage via sx prop
Jira: https://sagebionetworks.jira.com/browse/PORTALS-3651