PORTALS-3686, PORTALS-3687 #2039
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix issues in SynapseForm where search params were no longer passed to the component. We used to always inject the URLSearchParams as props to top-level portals components. This recently changed, breaking these components where these params must now be manually passed.
nickgros
commented
Jul 15, 2025
| export type SynapseFormWrapperProps = { | ||
| // Provide the parent container (folder/project), that should contain a folder (named <user_id>) that this user can write to. | ||
| formSchemaEntityId: string // Synapse file that contains the form schema. | ||
| formUiSchemaEntityId: string // Synapse file that contains the form ui schema. | ||
| formNavSchemaEntityId: string //Synapse file that consists screen nav schema | ||
| token?: string // user's access token | ||
| searchParams?: UploadToolSearchParams |
There was a problem hiding this comment.
We no longer automatically inject searchParams as a prop, which caused the regression (probably changed when we switched to lazy-loaded routes).
IMO searchParams as a prop is an antipattern--we are not directly dealing with routing and we want to avoid tightly coupling the implementation with the router.
Refactor here to make sure the former searchParam props are now all top-level props.
nickgros
commented
Jul 15, 2025
| @@ -0,0 +1,13 @@ | |||
| import { useSearchParams } from 'react-router' | |||
|
|
|||
| export function useGetFormPropsFromSearchParams() { | |||
There was a problem hiding this comment.
Utility to get these props out of the URL search params
jay-hodgson
approved these changes
Jul 15, 2025
Also remove outdated Story for ADKP
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issues in SynapseForm where search params were no longer passed to the component.
We used to always inject the URLSearchParams as props to top-level portals components. This recently changed, breaking these components where these params must now be manually passed.