-
Notifications
You must be signed in to change notification settings - Fork 20
Corrupted .dae file #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
huse360
wants to merge
36
commits into
Sage-of-Mirrors:master
Choose a base branch
from
LagoLunatic:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Made GameFormatReader a submodule, with the bugfix to reading floating point numbers * Downgraded to .net 4.5 * Upgraded to AssimpNet 4.1.0
These are no longer needed with AssimpNet 4.1.0. The node one actually completely breaks stuff.
This also makes material names look normal in Blender finally, no more "m17ear_2_" nonsense. However, the old sanitized format like "m17ear_2_" is still supported as legacy when converting dae -> bmd/bdl.
…l translucency via Assimp's opacity variable. Opacity is determined by the material's Alpha setting in Blender.
… single texture name
This is a hacky workaround for this assimp issue, since assimp.net doesn't receive updates: assimp/assimp#1417
In practice this doesn't seem to affect any materials in Wind Waker. But in theory, it could cause certain values to be truncated in the XF command.
… and lower nibbles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
In Wind Waker, when trying to export the file Link/bdl/cl.bdl to .dae, the output cl.dae file cannot be opened (take a look at the attachment, please)
Link.zip
https://www.xmlvalidation.com/index.php?id=1&L=0#xml-4393-89-1225185424
Then, I checked the .dae file into this online xml validator and says:
Errors in the XML document: