Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed materials not converting correctly if they have underscores in their name #8

Merged

Conversation

LagoLunatic
Copy link
Contributor

When materials are converted from BDL -> DAE, AssimpNet automatically converts parentheses in their names to underscores.
So then when loading the materials back from materials.json for converting DAE -> BMD, there's code that converts underscores back to parentheses.

But that code causes issues for material names that originally had underscores in their name (like a material in the Hero's Charm model), since the underscores are converted to parentheses and then detection of which material is which doesn't work.
So I changed how it compares material names so that it works correctly for materials that have underscores in them and also for ones that have parentheses in them.

@Sage-of-Mirrors Sage-of-Mirrors merged commit 84f73f7 into Sage-of-Mirrors:link May 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants