fix: Unhandled terminal mode in set_cursor implementation #1672
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the change
The
set_cursor
function on theblink.cmp.Context
did not handle terminal mode gracefully. Since terminal buffers support using thevim.api.nvim_win_set_cursor
function we can just extend the default behavior ofset_cursor
for terminal buffers.How I noticed the problem:
Every time I've tried to switch to the third (or more) completion entry by hitting my
select_next
keybind in a terminal buffer I ran into this error:Why I noticed the problem
I'm currently building zsh completions for blink.cmp. More on that in other PRs in a couple of days :).