fix(window): hide all blink windows when another completion menu is triggered #1852
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soifou
force-pushed
the
fix/complete-changed
branch
from
bd55bc0 to
bc455c5
Compare
soifou
changed the title
|
Rather than hiding all the windows through the window lib, it may make more sense to handle this in the trigger and call |
soifou
force-pushed
the
fix/complete-changed
branch
from
bc455c5 to
11ae0f6
Compare
|
This makes total sense since all the show/hide stuff is handled there. I pushed the changes as you suggested, and this feels now just right! Thanks for having pointed me in the right direction. |
…riggered If one or more blink windows (menu, documentation, or signature) are visible and the user triggers a different completion menu (like `omni-complete`, `user-complete`, ...), all blink windows are now closed automatically. This prevents the blink menu from staying open on top of the new menu, making things less confusing for users. Closes #1806
soifou
force-pushed
the
fix/complete-changed
branch
from
11ae0f6 to
2d6bc82
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If one or more blink windows (menu, documentation, or signature) are
visible and the user triggers a different completion menu (like
omni-complete,user-complete, ...), all blink windows are nowclosed automatically.
This prevents the blink menu from staying open on top of the new menu,
making things less confusing for users.
Closes #1806
2025-06-04_17-10-43.mp4
Same logic used by nvim-cmp and seems reliable enough.