fix: rust sorting provider order #1880
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using the Rust sorting implementation, the sort was applied at the provider level, rather than at the top level. This meant that the sort wouldn't sorts items across providers, and instead would concatenate the items from all the providers at the end, without sorting.
2 tasks
Saghen
force-pushed
the
fix/rust-sorting-provider-order
branch
from
35ad498 to
8c4cc47
Compare
mikavilpas
added a commit
to mikavilpas/dotfiles
that referenced
this pull request
Jun 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the Rust sorting implementation, the sort was applied at the
provider level, rather than at the top level. This meant that the sort
wouldn't sorts items across providers, and instead would concatenate the
items from all the providers at the end, without sorting.
Closes #1876
Closes #1846