Skip to content

fix: ! prefix completion #1912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 17, 2025
Merged

fix: ! prefix completion #1912

merged 1 commit into from
Jun 17, 2025

Conversation

phanen
Copy link
Contributor

@phanen phanen commented Jun 16, 2025

Don't work as expected for me(!ls -> ls) after dc647b3.

@phanen phanen force-pushed the fix-shellcmd branch 2 times, most recently from ed16c92 to 094b2c3 Compare June 16, 2025 15:32
@soifou
Copy link
Collaborator

soifou commented Jun 16, 2025

Nice catch! But we should probably fix the case with ranges then, like 2,3!sort -> 2,3sort—I don’t think that’s ever actually worked. Maybe the regex need to be adapted?

EDIT shellcmd need to be added in this condition:

elseif vim.tbl_contains({ 'lua', '' }, completion_type) then

This preserve ranges as well, can you confirm?

@phanen
Copy link
Contributor Author

phanen commented Jun 17, 2025

I can confirm this way much better.
Work both for ! and <range>!

@soifou soifou merged commit 9c5d823 into Saghen:main Jun 17, 2025
4 checks passed
@soifou
Copy link
Collaborator

soifou commented Jun 17, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants