Skip to content

Disable strict module name comparisons #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 12, 2025
Merged

Disable strict module name comparisons #12

merged 1 commit into from
Feb 12, 2025

Conversation

glopesdev
Copy link
Contributor

@glopesdev glopesdev commented Feb 12, 2025

The latest release of ruff introduced new strict rules for A005 which triggered CI errors due to module name comparisons. The pyproject.toml file was updated to disable strict module name comparison checks.

Fixes #11

@glopesdev glopesdev added the fix Pull request that fixes an issue label Feb 12, 2025
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.14%. Comparing base (1e40471) to head (f42656f).
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #12      +/-   ##
==========================================
+ Coverage   48.43%   51.14%   +2.70%     
==========================================
  Files          11       10       -1     
  Lines         638      614      -24     
==========================================
+ Hits          309      314       +5     
+ Misses        329      300      -29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glopesdev glopesdev merged commit be81192 into main Feb 12, 2025
3 checks passed
@glopesdev glopesdev deleted the ruff-checks branch February 12, 2025 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Pull request that fixes an issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider renaming io module or ignoring A005 ruff check
2 participants