Improve pose reader performance and avoid sorting #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add prefix anchor_ to anchor part name to avoid duplicates - Use numpy array slicing to reformat data without concat and sorting
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9 +/- ##
==========================================
+ Coverage 48.43% 51.14% +2.70%
==========================================
Files 11 10 -1
Lines 638 614 -24
==========================================
+ Hits 309 314 +5
+ Misses 329 300 -29 ☔ View full report in Codecov by Sentry. |
ttngu207
approved these changes
Feb 5, 2025
glopesdev
force-pushed
the
pose-reader
branch
2 times, most recently
from
28519d4 to
1a86fad
Compare
Co-authored-by: anayapouget <[email protected]>
glopesdev
force-pushed
the
pose-reader
branch
from
1a86fad to
15bd7a7
Compare
glopesdev
force-pushed
the
pose-reader
branch
from
508d1c4 to
3a74345
Compare
Multi-model config files are currently not supported by the acquisition package so we have no valid tests for this yet
glopesdev
force-pushed
the
pose-reader
branch
from
3a74345 to
a5e2800
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
anchor_to anchor part name to avoid duplicatesThe slicing allows for pairing values and timestamps correctly without the need for sorting. It also improves the interleaving of parts across the final array, as previously tie-breaks were resolved somehow by implicitly "grouping" part names together, whereas now values are grouped by identity, as follows naturally from the raw data.
Fixes #8