-
Notifications
You must be signed in to change notification settings - Fork 8
Add pre-commit with GitHub Actions (closes #8) #28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add pre-commit with GitHub Actions (closes #8) #28
Conversation
Summary of ChangesHello @shalmonTitree, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on minor cosmetic and formatting improvements across the project's README files. The changes primarily involve removing extraneous spaces and correctly formatting a URL, contributing to a cleaner and more consistent presentation of the documentation. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request applies automated formatting fixes to README.md and profile/README.md, presumably from the new pre-commit workflow mentioned in the description. The changes correctly wrap a bare URL for better link parsing and remove a trailing space, both of which improve code style and consistency. The applied changes are correct and beneficial.
jbampton
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What has been done here ?
Summary
Implements a GitHub Actions workflow to automatically run pre-commit hooks on every push and pull request.
Context
This work addresses issue SalamLang/.github#8.
It adds the missing workflow integration while keeping the existing directory structure.
Changes
.github/workflows/pre-commit.ymlworking-directory: .githubpre-commit run --all-files)Verification
✅ All hooks passed locally
✅ YAML validated
✅ No directory restructuring (per maintainer instructions)
Notes
Closes #8 once merged.