Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v6.0.0: Final release notes #3130

Merged
merged 9 commits into from
Oct 24, 2024
Merged

v6.0.0: Final release notes #3130

merged 9 commits into from
Oct 24, 2024

Conversation

krzywon
Copy link
Contributor

@krzywon krzywon commented Oct 18, 2024

Description

A final update to the release notes in preparation on the v6.0.0 release.

Licencing (untick if necessary)

  • The introduced changes comply with SasView license (BSD 3-Clause)

Added new configuration system change, it's the most significant change I've made.
@lucas-wilkins
Copy link
Contributor

As the config changes we actively cherry picked away in 5.0.6 it didn't get a mention. As it fixes the main bug that people report, I thought it deserved a mention. I've added it to the features.

@smk78
Copy link
Contributor

smk78 commented Oct 23, 2024

So I've made a couple more small changes, but overall I think these Release Notes are good to go.

However, I'm rather confused by the entry

One new model has been added to SasView since v5.0.6 was released:

[spin_structure_ferromagnets_3D](https://marketplace.sasview.org/models/140/) SANS in bulk ferromagnets by @stellhorn in https://github.com/SasView/sasmodels/pull/592

I've added the Marketplace link, but I don't see this model in RC2. Was RC2 built with sasmodels 1.0.8?

Is the spin_structure_ferromagnets_3D model supposed to be a new 'library' model in 6.0.0 or does the text 'One new model has been added to SasView since v5.0.6 was released:' need to be removed?

Copy link
Contributor

@smk78 smk78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved subject to resolution of the comment above.

@krzywon
Copy link
Contributor Author

krzywon commented Oct 23, 2024

So I've made a couple more small changes, but overall I think these Release Notes are good to go.

However, I'm rather confused by the entry

One new model has been added to SasView since v5.0.6 was released:

[spin_structure_ferromagnets_3D](https://marketplace.sasview.org/models/140/) SANS in bulk ferromagnets by @stellhorn in https://github.com/SasView/sasmodels/pull/592

I've added the Marketplace link, but I don't see this model in RC2. Was RC2 built with sasmodels 1.0.8?

Is the spin_structure_ferromagnets_3D model supposed to be a new 'library' model in 6.0.0 or does the text 'One new model has been added to SasView since v5.0.6 was released:' need to be removed?

I'll update this - it's called micromagnetic_FF_3D in sasmodels, not spin_structure_ferromagnets_3D.

@krzywon krzywon merged commit 4cc7904 into release_6.0.0 Oct 24, 2024
40 checks passed
@krzywon krzywon deleted the final-release-notes branch October 24, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants