Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2897, 2922: Use latest version of external (numpy, scipy, PySide) packages #3141

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

krzywon
Copy link
Contributor

@krzywon krzywon commented Oct 28, 2024

Description

This updates the requirements file to use the latest versions of PySide6, numpy, and scipy, while locking bumps to versions less than 1. This also updates ci.yml to include these changes, and adds periodictable to the parallel repo list until another release is made with fixes for numpy compatibility.

Fixes #2857
Fixes #2897
Fixes #2922

This is dependent on SasView/sasmodels#613 and SasView/sasdata#103 and will likely fail to build until they are merged.

How Has This Been Tested?

Locally, all tests pass and I am able to run the program without issue.

Review Checklist:

Documentation (check at least one)

  • There is nothing that needs documenting
  • Documentation changes are in this PR
  • There is an issue open for the documentation (link?)

Installers

  • There is a chance this will affect the installers, if so
    • Windows installer (GH artifact) has been tested (installed and worked)
    • MacOSX installer (GH artifact) has been tested (installed and worked)

Licencing (untick if necessary)

  • The introduced changes comply with SasView license (BSD 3-Clause)

.github/workflows/ci.yml Outdated Show resolved Hide resolved
Copy link
Member

@rozyczko rozyczko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks spiffy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants