Restore support for .NET Framework 4.8 (multi-targeting with .Net Core) #112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated the WPF MediaKit project and test application to target .NET Framework 4.8 along with .NET 8 and 9. - Added conditional references for DirectShowLib NuGet package based on the target framework (DirectShowLib for .NET Framework, DirectShowLib.Net for .NET 8/9). - Implemented #if preprocessor directive in DvdPlayer to handle code differences between the two packages (DirectShowLib and DirectShowLib.Net).
Author
|
Hello, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello !
This PR restores multi-targeting support for .NET Framework 4.8 along with .NET 8/9 in the WPF MediaKit project (and the Test Application).
What i have done:
I needed to replace the DirectShowLib-2005.dll with the DirectShowLib NuGet package, which makes managing versions easier and avoids relying on a specific DLL file (which is a real problem for me in my project).
In my case, moving to .NET Core is not an option due to project-specific dependencies, so maintaining support for .NET Framework is still necessary.
I don’t believe there’s a strong reason to stop supporting .NET Framework, as many projects still depend on it, especially in legacy environments.
If this PR is accepted, I’ll also work on making similar changes for DirectShowLib.Net, which will help clean up dependencies and remove the need for #if conditions in the code.
PS : I'll leave it to you to update the README.md and the version number, hoping that a NuGet package will be published soon!