Add multi promote support to publish/promote entity #1763
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sambible
added
entity
LadislavVasina1
approved these changes
Mar 20, 2025
vsedmik
reviewed
Mar 28, 2025
airgun/entities/contentview_new.py
Outdated
Comment on lines
55
to
62
| if promote and not multi_promote: | ||
| view.promote.click() | ||
| wait_for(lambda: view.lce_selector.is_displayed, timeout=10) | ||
| view.lce_selector.fill({lce: True}) | ||
| if promote and multi_promote: | ||
| view.promote.click() | ||
| wait_for(lambda: view.lce_selector.is_displayed, timeout=10) | ||
| view.lce_selector.fill(lce) |
There was a problem hiding this comment.
Could we use the lce being set (not None) as a flag that we want to do the multi-promote?
Something like
Suggested change
| if promote and not multi_promote: | |
| view.promote.click() | |
| wait_for(lambda: view.lce_selector.is_displayed, timeout=10) | |
| view.lce_selector.fill({lce: True}) | |
| if promote and multi_promote: | |
| view.promote.click() | |
| wait_for(lambda: view.lce_selector.is_displayed, timeout=10) | |
| view.lce_selector.fill(lce) | |
| if promote: | |
| view.promote.click() | |
| wait_for(lambda: view.lce_selector.is_displayed, timeout=10) | |
| view.lce_selector.fill(lce or {lce: True}) |
So when lce=None the {lce: True} is passed to the fill method, otherwise the lce is passed.
vsedmik
approved these changes
May 15, 2025
github-actions bot
pushed a commit
that referenced
this pull request
May 15, 2025
* Add multi promote support to publish/promote entity * Add wait_for checks to allow lce selector to load consistently * Simplify cv publish logic (cherry picked from commit c8d17e3)
github-actions bot
pushed a commit
that referenced
this pull request
May 15, 2025
* Add multi promote support to publish/promote entity * Add wait_for checks to allow lce selector to load consistently * Simplify cv publish logic (cherry picked from commit c8d17e3)
This was referenced May 15, 2025
LadislavVasina1
pushed a commit
that referenced
this pull request
May 16, 2025
LadislavVasina1
pushed a commit
that referenced
this pull request
May 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates publish entity to support multi environment promote.
Supports: SatelliteQE/robottelo#17949