-
Notifications
You must be signed in to change notification settings - Fork 66
hostgroups: PF5 update & navigation improvements #1819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
trigger: test-robottelo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK, addition looks good, waiting for PRT
For some reason the PRT didn't pick up the dependent PR #1812 . Therefore it failed. |
PatternFly5 updates for the host groups pages. Additional changes: - several `view.wait_displayed()` added for more reliable page loading - Host Groups page now also expects if no host groups are present - `hostgroup.read()` no longer submits the form - it can cause to submit unintentional data (not likely, but still) - it prolongs the test time as new page needs to load - the navigation can clash with actions chains like `read() && update(...)` where `read()` submits the form while `update()` expects to interact with the page immediately
9c96213
to
d972e52
Compare
trigger: test-robottelo |
Update: the PRT job can run only one airgun PR at a time. Specifying any dependent PR via the |
*** hostgroups: PF5 update & navigation improvements
Requires #1812
PatternFly5 updates for the host groups pages.
Additional changes:
view.wait_displayed()
added for more reliable page loadinghostgroup.read()
no longer submits the formread() && update(...)
where
read()
submitted the form whileupdate()
expects to interact with the page immediately*** PRT Example