Skip to content

hostgroups: PF5 update & navigation improvements #1819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2025

Conversation

pnovotny
Copy link
Contributor

*** hostgroups: PF5 update & navigation improvements

Requires #1812

PatternFly5 updates for the host groups pages.

Additional changes:

  • several view.wait_displayed() added for more reliable page loading
  • Host Groups page now also expects if no host groups are present
  • hostgroup.read() no longer submits the form
    • it can cause to submit unintentional data (not likely, but still)
    • it prolongs the test time as new page needs to load
    • the navigation can clash with actions chains like read() && update(...)
      where read() submitted the form while update() expects to interact with the page immediately

*** PRT Example

trigger: test-robottelo
pytest: tests/foreman/ui/test_hostgroup.py -k test_positive_end_to_end
airgun: 1812

@pnovotny pnovotny added the No-CherryPick PR doesnt need CherryPick to previous branches label Apr 25, 2025
@pnovotny pnovotny self-assigned this Apr 25, 2025
@pnovotny pnovotny requested review from a team April 25, 2025 11:07
@pnovotny
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_hostgroup.py -k test_positive_end_to_end
airgun: 1812

Copy link
Contributor

@LadislavVasina1 LadislavVasina1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, addition looks good, waiting for PRT

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Apr 25, 2025
@pnovotny
Copy link
Contributor Author

For some reason the PRT didn't pick up the dependent PR #1812 . Therefore it failed.
Investigating...

PatternFly5 updates for the host groups pages.

Additional changes:
- several `view.wait_displayed()` added for more reliable page loading
- Host Groups page now also expects if no host groups are present
- `hostgroup.read()` no longer submits the form
   - it can cause to submit unintentional data (not likely, but still)
   - it prolongs the test time as new page needs to load
   - the navigation can clash with actions chains like `read() && update(...)`
     where `read()` submits the form while `update()` expects to interact with the page immediately
@pnovotny pnovotny force-pushed the hostgroup-pf5-update1 branch from 9c96213 to d972e52 Compare April 25, 2025 18:43
@pnovotny
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_hostgroup.py -k test_positive_end_to_end

@pnovotny pnovotny removed the PRT-Failed Indicates that latest PRT run is failed for the PR label Apr 25, 2025
@pnovotny
Copy link
Contributor Author

pnovotny commented Apr 25, 2025

For some reason the PRT didn't pick up the dependent PR #1812 . Therefore it failed. Investigating...

Update: the PRT job can run only one airgun PR at a time. Specifying any dependent PR via the airgun: 123 statement actually does nothing in the airgun PRT job.

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Apr 25, 2025
@pondrejk pondrejk merged commit 2c3625e into SatelliteQE:master Apr 28, 2025
10 of 12 checks passed
@pnovotny pnovotny deleted the hostgroup-pf5-update1 branch April 29, 2025 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No-CherryPick PR doesnt need CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants