Skip to content

update alert msg after host delete #1900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

amolpati30
Copy link
Contributor

@amolpati30 amolpati30 commented Jun 28, 2025

Updated the alert message for host deletion. An unnecessary line removed, which was causing some tests to fail.

Summary by Sourcery

Bug Fixes:

  • Fix host deletion flash message by removing the redundant 'Success alert:' prefix to resolve test failures

@amolpati30 amolpati30 added CherryPick PR needs CherryPick to previous branches AutoMerge_Cherry_Picked Automatically merge the PR is PRT and all checks are passing 6.15.z 6.16.z 6.17.z labels Jun 28, 2025
Copy link

sourcery-ai bot commented Jun 28, 2025

Reviewer's Guide

Aligns the host deletion flash message with test expectations by removing the redundant 'Success alert:' prefix, fixing related test failures.

Class diagram for updated Host entity delete method

classDiagram
    class Host {
        +delete(entity_name, cancel=False)
    }
Loading

File-Level Changes

Change Details Files
Simplify host deletion alert message
  • Removed the "Success alert: " prefix from the deletion confirmation string
  • Updated the wait condition to match the new message format
airgun/entities/host.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @amolpati30 - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@amolpati30 amolpati30 force-pushed the update_assert_msg_after_host_del branch from 1bdae4b to beee8fa Compare June 28, 2025 12:14
lambda: view.flash.assert_message(
f"Success alert: Successfully deleted {entity_name}."
),
lambda: view.flash.assert_message(f"Successfully deleted {entity_name}."),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this success message updated for all Foreman/Satellite releases?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had previously added this for all supported versions, but since I'm encountering errors in Stream and 6.17z, I would prefer to keep this change applied to all versions to avoid any conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.15.z 6.16.z 6.17.z AutoMerge_Cherry_Picked Automatically merge the PR is PRT and all checks are passing CherryPick PR needs CherryPick to previous branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants