-
Notifications
You must be signed in to change notification settings - Fork 125
[SAT-26559] Incremental Update on a Version contained in a CompositeCV #18687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
PRT Result
|
bca8dbd
to
436174e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few changes requested, overall the logic looks sounds.
|
PRT Result
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK pending PRT.
PRT Result
|
^ failure to promote the incremental version (v2.1) to Edit: it's already promoted to |
|
PRT Result
|
|
PRT Result
|
:id: c8ab2dea-f51a-423e-ae1d-027fe6d85674 | ||
|
||
:setup: | ||
1. Composite ContentView with 3 regular ContentViews added, auto_publish set to False. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could be worded a little more clearly. To cover SAT-26559, the composite needs to both have auto_publish set to false and have all its child content views have 'Update to Latest Version'.
I understand this is specified below but I would personally make it clear it needs to happen at the CV level, not the repo level.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I can put it here too to be clearer. I'll also keep it below, to show the order of setup steps
:expectedresults: | ||
8. Incrementally Updated Filtered ContentView to v2.1, Composite updated to v1.1. | ||
9. CompositeCV contains all the newest CV Versions, except the Unfiltered-CV v3.0 (only expect v2.0). | ||
10. After final publish, CompositeCV now contains the Unfiltered-CV v3.0. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should probably be 1,2,3 not 8,9,10, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sometimes we'll number the expectedresults in order starting with 1 if they are pretty simple.
But if I have specific results expected at specific steps, I'll number result the same as the step that lead to it (from setup).
But, I could also split the :setup:
vs :steps:
better here, so will have that pushed soon.
|
PRT Result
|
|
PRT Result
|
*Note: The Version being incrementally updated is not a Version of the Composite, but a version of a filtered CV previously added to the composite.
PRT Case