Skip to content

[SAT-26559] Incremental Update on a Version contained in a CompositeCV #18687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

damoore044
Copy link
Contributor

@damoore044 damoore044 commented Jun 11, 2025

*Note: The Version being incrementally updated is not a Version of the Composite, but a version of a filtered CV previously added to the composite.

PRT Case

trigger: test-robottelo
pytest: tests/foreman/api/test_contentview.py::TestContentViewPublishPromote::test_positive_inc_update_ccv_updated_expected_version
Katello:
    katello: 11411

@damoore044 damoore044 self-assigned this Jun 11, 2025
@damoore044 damoore044 requested review from a team as code owners June 11, 2025 16:18
@damoore044 damoore044 added CherryPick PR needs CherryPick to previous branches Stream Introduced in or relating directly to Satellite Stream/Master 6.17.z labels Jun 11, 2025
@damoore044
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api/test_contentview.py::TestContentViewPublishPromote::test_positive_inc_update_cvv_updated_expected_version
Katello:
    katello: 11411

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 11724
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api/test_contentview.py::TestContentViewPublishPromote::test_positive_inc_update_cvv_updated_expected_version --external-logging
Test Result : ================== 1 failed, 7 warnings in 1212.93s (0:20:12) ==================

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Jun 11, 2025
@damoore044 damoore044 force-pushed the CompositeCV branch 2 times, most recently from bca8dbd to 436174e Compare June 11, 2025 19:16
Copy link
Contributor

@sambible sambible left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few changes requested, overall the logic looks sounds.

@damoore044
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api/test_contentview.py::TestContentViewPublishPromote::test_positive_inc_update_cvv_updated_expected_version
Katello:
    katello: 11411

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 11763
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api/test_contentview.py::TestContentViewPublishPromote::test_positive_inc_update_cvv_updated_expected_version --external-logging
Test Result : ================== 1 failed, 7 warnings in 1700.88s (0:28:20) ==================

@damoore044
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api/test_contentview.py::TestContentViewPublishPromote::test_positive_inc_update_cvv_updated_expected_version
Katello:
    katello: 11411

Copy link
Contributor

@sambible sambible left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK pending PRT.

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 11792
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api/test_contentview.py::TestContentViewPublishPromote::test_positive_inc_update_cvv_updated_expected_version --external-logging
Test Result : ================== 1 failed, 7 warnings in 1303.53s (0:21:43) ==================

@damoore044
Copy link
Contributor Author

damoore044 commented Jun 16, 2025

^ failure to promote the incremental version (v2.1) to Library. It's possible the API call promotes to Library already,
Locally, the CLI Hammer method, I still needed to promote the version after it was created, it was in no environments.
Should be a quick fix (famous last words)

Edit: it's already promoted to Library by api incremental update, removed the explicit promotion call.

@damoore044
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api/test_contentview.py::TestContentViewPublishPromote::test_positive_inc_update_ccv_updated_expected_version
Katello:
    katello: 11411

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 11794
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api/test_contentview.py::TestContentViewPublishPromote::test_positive_inc_update_ccv_updated_expected_version --external-logging
Test Result : ================== 1 failed, 7 warnings in 1320.96s (0:22:00) ==================

@damoore044
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api/test_contentview.py::TestContentViewPublishPromote::test_positive_inc_update_ccv_updated_expected_version
Katello:
    katello: 11411

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 11798
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api/test_contentview.py::TestContentViewPublishPromote::test_positive_inc_update_ccv_updated_expected_version --external-logging
Test Result : ================== 1 failed, 7 warnings in 1511.86s (0:25:11) ==================

:id: c8ab2dea-f51a-423e-ae1d-027fe6d85674

:setup:
1. Composite ContentView with 3 regular ContentViews added, auto_publish set to False.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be worded a little more clearly. To cover SAT-26559, the composite needs to both have auto_publish set to false and have all its child content views have 'Update to Latest Version'.

I understand this is specified below but I would personally make it clear it needs to happen at the CV level, not the repo level.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I can put it here too to be clearer. I'll also keep it below, to show the order of setup steps

:expectedresults:
8. Incrementally Updated Filtered ContentView to v2.1, Composite updated to v1.1.
9. CompositeCV contains all the newest CV Versions, except the Unfiltered-CV v3.0 (only expect v2.0).
10. After final publish, CompositeCV now contains the Unfiltered-CV v3.0.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably be 1,2,3 not 8,9,10, right?

Copy link
Contributor Author

@damoore044 damoore044 Jun 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sometimes we'll number the expectedresults in order starting with 1 if they are pretty simple.
But if I have specific results expected at specific steps, I'll number result the same as the step that lead to it (from setup).
But, I could also split the :setup: vs :steps: better here, so will have that pushed soon.

@damoore044
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api/test_contentview.py::TestContentViewPublishPromote::test_positive_inc_update_ccv_updated_expected_version
Katello:
    katello: 11411

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 11844
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api/test_contentview.py::TestContentViewPublishPromote::test_positive_inc_update_ccv_updated_expected_version --external-logging
Test Result : ================== 1 failed, 7 warnings in 1340.41s (0:22:20) ==================

@damoore044
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api/test_contentview.py::TestContentViewPublishPromote::test_positive_inc_update_ccv_updated_expected_version

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 11952
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api/test_contentview.py::TestContentViewPublishPromote::test_positive_inc_update_ccv_updated_expected_version --external-logging
Test Result : ================== 1 failed, 7 warnings in 1086.51s (0:18:06) ==================

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.17.z CherryPick PR needs CherryPick to previous branches PRT-Failed Indicates that latest PRT run is failed for the PR Stream Introduced in or relating directly to Satellite Stream/Master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants