Use url method to obtain correct protocol and adapt port accordingly #18696
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosas
added
CherryPick
|
Can one of the admins verify this patch? |
Comment on lines
+67
to
+68
| f'{session_puppet_enabled_sat.url}:9090/unattended/provision?token={host.token}', | ||
| verify=False, |
There was a problem hiding this comment.
For us, this puppet test is correctly able to reach url with specific port, and I haven't seen any issues with it yet, so I wonder is that a change for your setups? And, why it needs to adapt to the new port?
There was a problem hiding this comment.
At first I thought the same but then I checked where else this port is used and only found one occurrence. All the other places use the pattern from the PR. So this might have been a change that was forgotten?
Would you mind running the PRT for this test?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Statement
Puppet test unable to reach url with specific port
Solution
see commit message
Tests to run