[SAT-33810] New Hosts UI fix - VM setup #18753

damoore044 · 2025-06-17T15:17:45Z

Problem Statement

3 new host UI cases failing to setup their virtual machine, outdated args passed, custom repos not enabled, etc.

To parametrize implicitly, without putting a really ugly for loop in the test's parametrization,
I was able to get module_repos_collection_with_setup to work with distro in request, or without.
By falling back on globally defined fixture's RHEL host, declared rhel_version, if present.

^ Effect: We can still parametrize module_repos_collection_with_setup with distro explicitly as we currently do.
But if distro is None or missing, it will look for and fallback on fixture hosts with rhel_version.

Can now parametrize the module_repos_collection fixture with ubiquitous rhel markers: rhel_ver_match or rhel_ver_list.
^ but only if distro is missing, or None.

Solution

Resolved setup issues and local pass.
Implicitly parametrize module_repos_collection_with_setup for these cases by @pytest.mark.rhel_ver_match('N-1')
RHEL version / distro by N-1 (2 params for each of the 3 cases). N in stream is RHEL10.
^ instead of hardcoding to rhel8, which needs to be updated regularly or becomes outdated.

Needs: Airgun#1888

PRT Case

trigger: test-robottelo
pytest: tests/foreman/ui/test_host.py -k 'test_positive_crud_module_streams or test_positive_apply_erratum or test_positive_update_delete_package'

damoore044 · 2025-06-17T15:23:37Z

trigger: test-robottelo
pytest: tests/foreman/ui/test_host.py -k 'test_positive_crud_module_streams or test_positive_apply_erratum or test_positive_update_delete_package'

Satellite-QE · 2025-06-17T19:08:25Z

PRT Result

Build Number: 11818
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_host.py -k test_positive_crud_module_streams or test_positive_apply_erratum or test_positive_update_delete_package --external-logging
Test Result : ========= 6 failed, 82 deselected, 748 warnings in 12898.16s (3:34:58) =========

damoore044 · 2025-06-18T15:42:13Z

trigger: test-robottelo
pytest: tests/foreman/ui/test_host.py::test_positive_crud_module_streams[rhel10-ipv4-module_stream_1]

Satellite-QE · 2025-06-18T16:12:50Z

PRT Result

Build Number: 11843
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_host.py::test_positive_crud_module_streams[rhel10-ipv4-module_stream_1] --external-logging
Test Result : ================= 1 failed, 13 warnings in 1235.88s (0:20:35) ==================

damoore044 · 2025-06-20T16:34:39Z

trigger: test-robottelo
pytest: tests/foreman/ui/test_host.py::test_positive_crud_module_streams[rhel10-ipv4-module_stream_1]

damoore044 · 2025-06-20T16:35:40Z

trigger: test-robottelo
pytest: tests/foreman/ui/test_host.py::test_positive_crud_module_streams[rhel10-ipv6-module_stream_1]
network_type: ipv6

damoore044 · 2025-06-20T17:00:50Z

trigger: test-robottelo
pytest: tests/foreman/ui/test_host.py::test_positive_crud_module_streams[rhel10-ipv4-module_stream_1]
airgun: 1888

Satellite-QE · 2025-06-20T17:27:36Z

PRT Result

Build Number: 11873
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_host.py::test_positive_crud_module_streams[rhel10-ipv4-module_stream_1] --external-logging
Test Result : ================= 1 failed, 14 warnings in 1220.23s (0:20:20) ==================

Satellite-QE · 2025-06-20T18:06:24Z

PRT Result

Build Number: 11875
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_host.py::test_positive_crud_module_streams[rhel10-ipv4-module_stream_1] --external-logging
Test Result : ================= 1 failed, 14 warnings in 1246.03s (0:20:46) ==================

Satellite-QE · 2025-06-20T19:39:40Z

PRT Result

Build Number: 11877
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_host.py::test_positive_crud_module_streams[rhel10-ipv4-module_stream_1] --external-logging
Test Result : ================= 1 failed, 14 warnings in 2106.19s (0:35:06) ==================

Copilot

Pull Request Overview

This PR modernizes RHEL version handling in UI tests, updates VM setup invocation, enhances custom repo enabling logic, and streamlines repo fixtures.

Switches hardcoded rhel8 markers to dynamic N-1 and refactors setup_virtual_machine calls to use enable_custom_repos
Adds SCA fallback via subscription-manager in contenthost_setup and enriches error output
Implements a fallback for missing distro in module_repos_collection_with_setup based on pytest markers

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File	Description
tests/foreman/ui/test_host.py	Updated parametrization to use `N-1`, removed explicit `distro`, changed VM setup args
tests/foreman/ui/test_errata.py	Simplified cleanup `if client and client.subscribed`
robottelo/hosts.py	Added subscription-manager enable attempt with fallback and error detail
pytest_fixtures/component/repository.py	Added logic to derive `distro` from top‐level markers

robottelo/hosts.py

pytest_fixtures/component/repository.py

tests/foreman/ui/test_errata.py

… host fixtures, if present

vsedmik · 2025-07-09T11:33:05Z

trigger: test-robottelo
pytest: tests/foreman/ui/test_host.py::test_positive_crud_module_streams[rhel10-ipv4-module_stream_1]
airgun: 1888

vsedmik

Codewisely looks good to me (just one nit), but I wasn't able to find the PRT result to dig into the previous failure. Rerunning now. 🤞

vsedmik · 2025-07-09T11:38:29Z

pytest_fixtures/component/repository.py

+    if repos['distro'] is None:
+        repos['distro'] = fixtures_distro
+    if repos['distro'] and 'rhel' not in str(repos['distro']):
+        repos['distro'] = 'rhel' + str(repos['distro'])


Suggested change

repos['distro'] = 'rhel' + str(repos['distro'])

repos['distro'] = f'rhel{repos['distro']}'

Satellite-QE · 2025-07-09T12:06:17Z

PRT Result

Build Number: 12027
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_host.py::test_positive_crud_module_streams[rhel10-ipv4-module_stream_1] --external-logging
Test Result : ================= 1 failed, 14 warnings in 1395.07s (0:23:15) ==================

vsedmik · 2025-07-09T12:25:38Z

PRT failed with selenium.common.exceptions.NoSuchElementException: Message: Could not find an element Locator(by='xpath', locator='./button');

Is it something to be addressed in SatelliteQE/airgun#1888 @damoore044 ?

damoore044 self-assigned this Jun 17, 2025

damoore044 requested a review from a team as a code owner June 17, 2025 15:17

damoore044 added Easy Fix :) Easiest Fix to review and quick merge request. CherryPick PR needs CherryPick to previous branches Stream Introduced in or relating directly to Satellite Stream/Master 6.16.z Introduced in or relating directly to Satellite 6.16 6.17.z labels Jun 17, 2025

Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Jun 17, 2025

damoore044 force-pushed the vm_setup_new_host branch from 1456ad5 to e763531 Compare June 18, 2025 15:40

damoore044 requested a review from a team as a code owner June 18, 2025 15:40

damoore044 requested a review from a team June 18, 2025 15:40

damoore044 removed the Easy Fix :) Easiest Fix to review and quick merge request. label Jun 18, 2025

damoore044 force-pushed the vm_setup_new_host branch from e763531 to 85633ad Compare June 20, 2025 16:33

damoore044 requested a review from JacobCallahan June 20, 2025 16:34

damoore044 force-pushed the vm_setup_new_host branch 2 times, most recently from fd6c3c6 to a8f5460 Compare June 20, 2025 16:49

damoore044 force-pushed the vm_setup_new_host branch from a8f5460 to 62f7d09 Compare July 1, 2025 19:21

damoore044 requested a review from a team as a code owner July 1, 2025 19:21

JacobCallahan requested a review from Copilot July 1, 2025 19:54

Copilot AI reviewed Jul 1, 2025

View reviewed changes

robottelo/hosts.py Outdated Show resolved Hide resolved

robottelo/hosts.py Outdated Show resolved Hide resolved

pytest_fixtures/component/repository.py Show resolved Hide resolved

tests/foreman/ui/test_errata.py Show resolved Hide resolved

damoore044 force-pushed the vm_setup_new_host branch from 62f7d09 to 5eabcd6 Compare July 3, 2025 13:51

damoore044 added 2 commits July 7, 2025 12:02

VM setup, module_streams, custom repos and content

36ce4e9

module_repos_collection_with_setup: fallback distro from parametrized…

ff9994f

… host fixtures, if present

damoore044 force-pushed the vm_setup_new_host branch from 5eabcd6 to ff9994f Compare July 7, 2025 16:27

vsedmik reviewed Jul 9, 2025

View reviewed changes

	repos['distro'] = 'rhel' + str(repos['distro'])
	repos['distro'] = f'rhel{repos['distro']}'

[SAT-33810] New Hosts UI fix - VM setup #18753

Are you sure you want to change the base?

[SAT-33810] New Hosts UI fix - VM setup #18753

Conversation

damoore044 commented Jun 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem Statement

Solution

PRT Case

Uh oh!

damoore044 commented Jun 17, 2025

Uh oh!

Satellite-QE commented Jun 17, 2025

Uh oh!

damoore044 commented Jun 18, 2025

Uh oh!

Satellite-QE commented Jun 18, 2025

Uh oh!

damoore044 commented Jun 20, 2025

Uh oh!

damoore044 commented Jun 20, 2025

Uh oh!

damoore044 commented Jun 20, 2025

Uh oh!

Satellite-QE commented Jun 20, 2025

Uh oh!

Satellite-QE commented Jun 20, 2025

Uh oh!

Satellite-QE commented Jun 20, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vsedmik commented Jul 9, 2025

Uh oh!

vsedmik left a comment

Choose a reason for hiding this comment

Uh oh!

vsedmik Jul 9, 2025

Choose a reason for hiding this comment

Uh oh!

Satellite-QE commented Jul 9, 2025

Uh oh!

vsedmik commented Jul 9, 2025

Uh oh!

Uh oh!

damoore044 commented Jun 17, 2025 •

edited

Loading