Skip to content

Add RHEL 10 to OS path fixture #18808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add RHEL 10 to OS path fixture #18808

wants to merge 1 commit into from
+4 −8

Conversation

lhellebr
Copy link
Contributor

No description provided.

@lhellebr lhellebr requested a review from a team as a code owner June 25, 2025 11:21
@lhellebr
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_host.py::test_positive_create_and_update_with_content_source

@lhellebr lhellebr changed the title Add RHEL 10 Add RHEL 10 to OS path fixture Jun 25, 2025
@lhellebr lhellebr added CherryPick PR needs CherryPick to previous branches 6.15.z Introduced in or relating directly to Satellite 6.15 6.16.z Introduced in or relating directly to Satellite 6.16 6.17.z labels Jun 25, 2025
@lhellebr lhellebr requested a review from a team June 25, 2025 11:22
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 11909
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_host.py::test_positive_create_and_update_with_content_source --external-logging
Test Result : ================= 1 passed, 15 warnings in 1953.41s (0:32:33) ==================

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Jun 25, 2025
Gauravtalreja1
Gauravtalreja1 requested changes Jun 25, 2025
View reviewed changes
pytest_fixtures/component/os.py Outdated
Comment on lines 50 to 51
elif default_os.major == "10":
os_distr_url = settings.repos.rhel10_os.baseos
Copy link
Collaborator

@Gauravtalreja1 Gauravtalreja1 Jun 25, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest to make this fixture future-proof with something like

Suggested change
elif default_os.major == "10":
os_distr_url = settings.repos.rhel10_os.baseos
if int(default_os.major) <= 7:
os_distr_url = getattr(settings.repos, f'rhel{default_os.major}_os')
elif int(default_os.major) > 7:
os_distro_url = getattr(settings.repos, f'rhel{default_os.major}_os').baseos
else:
pytest.fail('Proposed RHEL version is not supported')

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not. When doing these changes, I intend to keep them minimal but this little refactor should be ok.

pytest_fixtures/component/os.py
@@ -47,6 +47,8 @@ def os_path(default_os):
os_distr_url = settings.repos.rhel8_os.baseos
elif default_os.major == "9":
os_distr_url = settings.repos.rhel9_os.baseos
elif default_os.major == "10":
os_distr_url = settings.repos.rhel10_os.baseos
else:
pytest.fail('Proposed RHEL version is not supported')
return os_distr_url
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/os_distr_url/os_distro_url

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it's really os_distr_url

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does it mean?

@Gauravtalreja1 Gauravtalreja1 added the AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing label Jun 25, 2025
@lhellebr
Copy link
Contributor Author

lhellebr commented Jul 9, 2025

trigger: test-robottelo
pytest: tests/foreman/cli/test_host.py::test_positive_create_and_update_with_content_source

@Satellite-QE Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label Jul 9, 2025
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 12030
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_host.py::test_positive_create_and_update_with_content_source --external-logging
Test Result : ================= 1 failed, 15 warnings in 1789.17s (0:29:49) ==================

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Jul 9, 2025
@lhellebr
Copy link
Contributor Author

lhellebr commented Jul 9, 2025

trigger: test-robottelo
pytest: tests/foreman/cli/test_host.py::test_positive_create_and_update_with_content_source

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 12031
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_host.py::test_positive_create_and_update_with_content_source --external-logging
Test Result : ================= 1 failed, 15 warnings in 1785.13s (0:29:45) ==================

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gauravtalreja1 Gauravtalreja1 Gauravtalreja1 requested changes

@amolpati30 amolpati30 amolpati30 approved these changes

Assignees

@lhellebr lhellebr

Labels
6.15.z Introduced in or relating directly to Satellite 6.15 6.16.z Introduced in or relating directly to Satellite 6.16 6.17.z AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches PRT-Failed Indicates that latest PRT run is failed for the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lhellebr @Satellite-QE @Gauravtalreja1 @amolpati30