Move get_satellite_capsule_repos logic to VersionedContent class

[Copilot]

This PR moves the get_satellite_capsule_repos function from tests/foreman/maintain/test_advanced.py to the VersionedContent class in robottelo/host_helpers/contenthost_mixins.py as requested in the issue.

Changes Made

1. Added get_satellite_capsule_repos() method to VersionedContent class

• Located in robottelo/host_helpers/contenthost_mixins.py
• Maintains the same API and functionality as the original function
• Properly integrated into the host object hierarchy
• Uses self._v_major for OS version detection and settings.server.version.release for satellite version defaults

2. Updated test file usage

• Modified all 4 usage locations in tests/foreman/maintain/test_advanced.py
• Changed from get_satellite_capsule_repos(...) to sat_maintain.get_satellite_capsule_repos(...)
• Preserved all original parameter passing patterns

3. Code cleanup

• Removed the original standalone function from the test file
• Removed unused imports (get_sat_rhel_version, get_sat_version)
• Maintained clean, readable code structure

Validation

The changes maintain backward compatibility while properly organizing the code according to the repository's architecture. The method generates the same repository lists as the original function:

# Example output for satellite repos on RHEL 9
['satellite-6.16-for-rhel-9-x86_64-rpms', 
 'satellite-maintenance-6.16-for-rhel-9-x86_64-rpms', 
 'rhel-9-for-x86_64-baseos-rpms', 
 'rhel-9-for-x86_64-appstream-rpms']

The implementation leverages the existing host object structure where Satellite and Capsule instances inherit from VersionedContent through the ContentHostMixins chain, making the method naturally available on both host types.

Fixes #12492.

---

💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.

[Satellite-QE]

Can one of the admins verify this patch?

[JacobCallahan]

ACK on the concept of the changes. However, @ogajduse can you verify this fits with your intent? Also, not sure if it's better to reference the settings to get the x_y release or to pull that from a self._satellite attribute if available.

[JacobCallahan]

@copilot pre-commit checks are failing due to trailing whitespace characters. please adjust.

trim trailing whitespace.................................................Failed
- hook id: trailing-whitespace
- exit code: 1
- files were modified by this hook

Fixing robottelo/host_helpers/contenthost_mixins.py

[Copilot]

@copilot pre-commit checks are failing due to trailing whitespace characters. please adjust.

...

Fixed the trailing whitespace issue in robottelo/host_helpers/contenthost_mixins.py. The pre-commit checks should now pass. (8656ba2)

[ogajduse]

I'd question the need for having the get_satellite_capsule_repos function. There may be place for it, but I'd say it could be flattened if we'd use REPOS and CAPSULE_CDN_REPOS cached properties defined in the VersionedContent class.

[ogajduse]

There already is an existing implementation in

robottelo/robottelo/host_helpers/contenthost_mixins.py

Lines 25 to 26 in adf5ff5

	'rhel_bos': constants.REPOSET[f'rhel{self._v_major}_bos'],
	'rhel_aps': constants.REPOSET[f'rhel{self._v_major}_aps'],

that gives us RHEL repositories. Could it be reused here in this function?

[Copilot]

Good point! The function now reuses the existing RHEL repository implementation by using self.REPOS['rhel_bos']['id'] and self.REPOS['rhel_aps']['id'] instead of manually generating the repository names. This leverages the same well-tested logic that's already in the VersionedContent class. (2646f16)

[ogajduse]

The product repositories could be generated by the existing CAPSULE_CDN_REPOS cached_property. Again, could it be reused here in this function?

[Copilot]

Exactly! The function now uses self.CAPSULE_CDN_REPOS.values() (and self.SATELLITE_CDN_REPOS.values()) to generate the product repositories when the parameters match the default configuration. This eliminates the duplication and leverages the existing cached property logic. (2646f16)

[Copilot]

I'd question the need for having the get_satellite_capsule_repos function. There may be place for it, but I'd say it could be flattened if we'd use REPOS and CAPSULE_CDN_REPOS cached properties ...

You're absolutely right! I've refactored the function to use the existing REPOS and CAPSULE_CDN_REPOS cached properties. The function now leverages these cached properties when parameters match the host's default configuration, eliminating duplication of repository name generation logic. It falls back to manual generation only when custom parameters are provided. (2646f16)

[jameerpathan111]

This won't work for stream. The repository names will include stream. It has to be the satellite version. Also, def REPOS provides capsule repo too, which it shouldn't. It's probably good to add logic based on SATELLITE_VERSION from robottelo/constants/__init__.py.